Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the fixtures for scoring of signal bug probe#2627 #842

Merged
merged 4 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    78527f0 View commit details
    Browse the repository at this point in the history
  2. Correct the fixtures for scoring of bug 2627

    * The integration test was using as a fixture measurement from
      before the incident
    (https://explorer.ooni.org/m/20210427000432.751743_AU_signal_490428d8ebc76e6b),
    but was expecting it to be marked as failed
    * The unit test was using a measurement that was from a newer version of
      probe
    (https://explorer.ooni.org/measurement/20221118T104419Z_signal_IT_30722_n1_Q02UUAiiHlVU0VE6),
    which should not be marked as failed either
    
    As part of #831 we improved the
    logic for scoring to be more precise and so these checks were now
    failing.
    
    We now use in both cases a correct "bad case" and in the unit test we
    also include the previous case as a "good case".
    hellais committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    57a02b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    220ffdd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    af44a9a View commit details
    Browse the repository at this point in the history