Correct the fixtures for scoring of signal bug probe#2627 #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The integration test was using as a fixture measurement from before the incident (https://explorer.ooni.org/m/20210427000432.751743_AU_signal_490428d8ebc76e6b), but was expecting it to be marked as failed * The unit test was using a measurement that was from a newer version of probe (https://explorer.ooni.org/measurement/20221118T104419Z_signal_IT_30722_n1_Q02UUAiiHlVU0VE6), which should not be marked as failed either As part of #831 we improved the logic for scoring to be more precise and so these checks were now failing. We now use in both cases a correct "bad case" and in the unit test we also include the previous case as a "good case".
hellais
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before the incident
(https://explorer.ooni.org/m/20210427000432.751743_AU_signal_490428d8ebc76e6b),
but was expecting it to be marked as failed
probe
(https://explorer.ooni.org/measurement/20221118T104419Z_signal_IT_30722_n1_Q02UUAiiHlVU0VE6),
which should not be marked as failed either
As part of #831 we improved the
logic for scoring to be more precise and so these checks were now
failing.
We now use in both cases a correct "bad case" and in the unit test we
also include the previous case as a "good case".