Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(probe_services): disable torsf #829

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(probe_services): disable torsf #829

merged 1 commit into from
Mar 25, 2024

Conversation

bassosimone
Copy link
Contributor

This diff uses richer input to disable the torsf experiment. This works under the assumption that probes periodically call check-in and refresh feature flags, which should be true for the probes maintained by the OONI team.

Mitigation for ooni/probe#2692

This diff uses richer input to disable the torsf experiment. This works under
the assumption that probes periodically call check-in and refresh feature flags,
which should be true for the probes maintained by the OONI team.

Mitigation for ooni/probe#2692
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6258173) to head (e6c2446).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #829   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1448      1448           
  Branches       116       116           
=========================================
  Hits          1448      1448           
Flag Coverage Δ
ooniauth 100.00% <ø> (ø)
oonirun 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellais hellais merged commit 9414037 into master Mar 25, 2024
6 checks passed
@hellais hellais deleted the issue/2692-mitigation branch March 25, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants