Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: when a collector in OTHER_COLLECTORS is unreachable, the fetch body does not timeout #878

Open
hellais opened this issue Sep 5, 2024 · 0 comments

Comments

@hellais
Copy link
Member

hellais commented Sep 5, 2024

This was noticed in "fresh" measurements where the logic is to try to fetch the bodies in this order:

  • From disk
  • From the list of collectors specified in the OTHER_COLLECTOR setting
  • From s3

For some reason if one of the OTHER_COLLECTORS is unreachable, the connection doesn't timeout in time, leading to a failure in retrieving the measurement.

We should look into either setting the urllib3 connection pool timeout or understand how we can make sure the failure is properly triggered so it doesn't stay hanging.

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants