Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak health checks for ooni services #872

Open
DecFox opened this issue Aug 10, 2024 · 0 comments
Open

Weak health checks for ooni services #872

DecFox opened this issue Aug 10, 2024 · 0 comments

Comments

@DecFox
Copy link
Contributor

DecFox commented Aug 10, 2024

It seems we have weak health checks which easily bypass the docker-smoketest we have. This can also be seen in the codepipeline logs:

+ docker logs ooniapi-smoketest-20970
--
531 | INFO:     Started server process [1]
532 | INFO:     Waiting for application startup.
533 | INFO:     Application startup complete.
534 | INFO:     Uvicorn running on http://0.0.0.0:80 (Press CTRL+C to quit)
535 | (psycopg2.OperationalError) connection to server at "localhost" (127.0.0.1), port 5432 failed: Connection refused
536 | Is the server running on that host and accepting TCP/IP connections?
537 | connection to server at "localhost" (::1), port 5432 failed: Cannot assign requested address
538 | Is the server running on that host and accepting TCP/IP connections?
539 |  
540 | (Background on this error at: https://sqlalche.me/e/20/e3q8)
541 | INFO:     172.18.0.1:34152 - "GET /health HTTP/1.1" 200 OK

We should trandform these into real health check for the services. The key component missing here is passing the required environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants