Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search::setSource() now has a wrong phpdoc for the $source argument #254

Open
pmishev opened this issue Mar 22, 2018 · 0 comments
Open

Search::setSource() now has a wrong phpdoc for the $source argument #254

pmishev opened this issue Mar 22, 2018 · 0 comments

Comments

@pmishev
Copy link
Contributor

pmishev commented Mar 22, 2018

For some reason, you've changed the correct @param array|bool|string $source to be @param bool $source in setSource() and now I'm getting warnings in PhpStorm when I pass an array to it.

48df0dc#diff-e2ebe118f1e8dc3ba0a0e79a061a15ffL535
event15 added a commit to event15/ElasticsearchDSL that referenced this issue Jul 8, 2020
@event15
Update Search.php
50f9b9f 
Change annotation for setSource method reported in ongr-io#254
@event15 event15 mentioned this issue Jul 8, 2020
Merged
alexander-schranz pushed a commit to handcraftedinthealps/ElasticsearchDSL that referenced this issue Feb 17, 2021
@event15
Update Search.php (#7)
e8a5d53 
Change annotation for setSource method reported in ongr-io#254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmishev