Module bundles

.pre-commit-config.yaml

@@ -2,17 +2,10 @@
 exclude: |
   (?x)
   # NOT INSTALLABLE ADDONS
-  ^accountancy_install/|
   ^base_mail_security/|
   ^base_partner_security/|
   ^base_user_limit/|
-  ^community_org_install/|
   ^container_hr_recruitment/|
-  ^container_install_standard/|
-  ^project_org_install/|
-  ^services_org_install/|
-  ^trade_org_install/|
-  ^university_org_install/|
   # END NOT INSTALLABLE ADDONS
   # Files and folders generated by bots, to avoid loops
   ^setup/|/static/description/index\.html$|

account_install/__manifest__.py

@@ -0,0 +1,58 @@
+{
+    "name": "Accounting",
+    "summary": "Invoices, Contracts & Payments",
+    "author": "Onestein",
+    "category": "Accounting",
+    "version": "16.0.1.0.0",
+    "license": "AGPL-3",
+    "depends": [
+        "account",
+        "account_payment_mode",
+        "account_payment_order",
+        "account_payment_partner",
+        "account_fiscal_position_vat_check",
+        "account_invoice_constraint_chronology",
+        "account_invoice_line_default_account",
+        "account_journal_lock_date",
+        "account_lock_date_update",
+        "account_move_print",
+        "account_usability",
+        "base_vat_optional_vies",
+        "account_reconcile_oca",
+        "account_statement_base",
+        "account_payment_sale",
+        "product_margin",
+        "account_financial_report",
+        "product_category_product_link",
+        "account_statement_import_camt",
+        "account_statement_import_camt54",
+        "account_statement_import_file_reconcile_oca",
+        "account_period_auto_create",
+        "account_statement_import_online_ponto",
+        "account_statement_import_online_ponto_statement_creation_mode",
+        "account_statement_import_sheet_file",
+        "account_statement_import_sheet_file_sheet_mappings",
+        "account_move_line_attachment_preview",
+        "account_configuration",
+        "account_invoice_overdue_reminder",
+        "account_move_line_tax_editable",
+        "account_move_tier_validation",
+        "account_statement_import_online_paypal",
+        "contract",
+        "contract_payment_mode",
+        "currency_rate_update",
+        "l10n_nl_rgs",
+        "l10n_nl_rgs_usability",
+        "l10n_nl_rgs_mis_report",
+        "l10n_nl_rgs_account_financial_report",
+        "l10n_nl_rgs_asset",
+        "l10n_nl_bank",
+        "l10n_nl_xaf_auditfile_export",
+        "l10n_nl_tax_statement",
+        "l10n_nl_tax_statement_date_range",
+        "l10n_nl_tax_statement_icp",
+        "mollie_account_sync",
+        "payment_mollie_official",
+    ],
+    "bundle": True,
+}

base_module_bundle/__init__.py

@@ -0,0 +1,2 @@
+from . import models
+from . import wizards

base_module_bundle/__manifest__.py

@@ -0,0 +1,10 @@
+{
+    "name": "Module Bundles",
+    "category": "Technical",
+    "version": "16.0.1.0.0",
+    "author": "Onestein",
+    "website": "https://onestein.nl",
+    "depends": ["base_setup"],
+    "data": [],
+    "license": "LGPL-3",
+}

base_module_bundle/models/__init__.py

@@ -0,0 +1 @@
+from . import ir_module_module

base_module_bundle/models/ir_module_module.py

@@ -0,0 +1,44 @@
+from odoo import conf, fields, models
+
+
+class IrModuleModule(models.Model):
+    _inherit = "ir.module.module"
+
+    is_bundle = fields.Boolean(
+        help="A bundle purges dependencies on uninstallation of this module",
+        compute="_compute_is_bundle",
+    )  # Can't be stored
+
+    def _compute_is_bundle(self):
+        for module in self:
+            module_info = self.get_module_info(module.name)
+            module.is_bundle = module_info.get("bundle", False)
+
+    def _get_modules_to_uninstall_for_bundle(self):
+        self.ensure_one()
+        other_installed_bundle_modules = self.search(
+            [("state", "=", "installed"), ("id", "!=", self.id)]
+        ).filtered(lambda m: m.is_bundle)
+        modules_to_keep = self.search([("name", "in", conf.server_wide_modules)])
+        modules_to_keep += other_installed_bundle_modules.upstream_dependencies(
+            exclude_states=("uninstalled",)
+        )
+        modules_to_keep = set(modules_to_keep)
+        modules_to_remove = self.upstream_dependencies(exclude_states=("uninstalled",))
+        modules_to_remove = modules_to_remove.filtered(
+            lambda d: d not in modules_to_keep
+        )
+        return modules_to_remove
+
+    def button_uninstall(self):
+        """
+        Uninstall upstream modules but only if they're not in another bundle modules dependency.
+        This will not be invoked if a dependency of a bundle is uninstalled, only when a bundle is directly uninstalled
+        """
+        modules = self.search([("state", "=", "installed")])
+        bundle_modules = modules.filtered(lambda m: m.is_bundle)
+        for to_uninstall in self.filtered(lambda m: m in bundle_modules):
+            modules_to_remove = to_uninstall._get_modules_to_uninstall_for_bundle()
+            modules_to_remove.write({"state": "to remove"})
+
+        return super().button_uninstall()

base_module_bundle/wizards/__init__.py

@@ -0,0 +1 @@
+from . import base_module_uninstall

base_module_bundle/wizards/base_module_uninstall.py

@@ -0,0 +1,16 @@
+from odoo import api, models
+
+
+class ModuleUninstall(models.TransientModel):
+    _inherit = "base.module.uninstall"
+
+    def _get_modules(self):
+        modules = super()._get_modules()
+        if not self.module_id.is_bundle:
+            return modules
+        modules += self.module_id._get_modules_to_uninstall_for_bundle()
+        return modules
+
+    @api.depends("module_id.is_bundle")
+    def _compute_module_ids(self):
+        return super()._compute_module_ids()

base_onboarding/__manifest__.py

@@ -4,11 +4,11 @@
 {
     "name": "Onboarding",
     "author": "Onestein",
-    "website": "https://www.onestein.eu",
+    "website": "https://onestein.nl",
     "category": "Extra Tools",
     "version": "16.0.1.0.0",
     "license": "AGPL-3",
-    "depends": ["website", "multi_step_wizard", "web", "mail"],
+    "depends": ["multi_step_wizard", "web", "mail"],
     "data": [
         "security/res_groups.xml",
         "security/ir.model.access.csv",

base_onboarding/models/__init__.py

@@ -1,2 +1,2 @@
-from . import ir_module_module
 from . import base_document_layout
+from . import ir_module_module

base_onboarding/models/ir_module_module.py

@@ -1,29 +1,17 @@
-from odoo import api, models
+from odoo import models
 
 
 class IrModuleModule(models.Model):
     _inherit = "ir.module.module"
 
-    @api.model
-    def _fields_view_get(
-        self, view_id=None, view_type="form", toolbar=False, submenu=False
-    ):
-        if (
-            view_type == "kanban"
-            and self.env.context.get("active_model") == "base.onboarding.wizard"
-        ):
-            view_id = self.env.ref("website.theme_view_kanban").id
-        return super()._fields_view_get(
-            view_id=view_id, view_type=view_type, toolbar=toolbar, submenu=submenu
-        )
+    def button_immediate_install(self):
+        res = super().button_immediate_install()
+        if self.env.context.get("onboarding_wizard", False):
+            return {"type": "ir.actions.act_url", "url": "/web", "target": "self"}
+        return res
 
-    def button_choose_theme(self):
-        res = super().button_choose_theme()
-        if self.env.context.get("active_model") == "base.onboarding.wizard":
-            wizard = self.env["base.onboarding.wizard"].search(
-                [("id", "=", self.env.context.get("active_id"))]
-            )
-            if wizard.state == "theme":
-                wizard.open_next()
-            res = wizard._reopen_self()
+    def button_immediate_uninstall(self):
+        res = super().button_immediate_uninstall()
+        if self.env.context.get("onboarding_wizard", False):
+            return {"type": "ir.actions.act_url", "url": "/web", "target": "self"}
         return res