Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release SOP v4 #14

Merged
merged 2 commits into from
May 30, 2024
Merged

Release SOP v4 #14

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23f9e90
Upload SOP v4
zhx828 May 30, 2024
f316289
Align version text with the one in SOP document
zhx828 May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<span id="current-version-span"></span>
</button>
<ul class="dropdown-menu" aria-labelledby="previousVersionDropdown">
<li><a class="dropdown-item" href="#" value="v4">Version 4</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there two version 3's? v3.0 and v3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To support https://sop.oncokb.org/?version=v3.0 But I think I can make a slight change in script to avoid the dup. Let me work on that.

<li><a class="dropdown-item" href="#" value="v3.1">Version 3.1</a></li>
<li><a class="dropdown-item" href="#" value="v3">Version 3</a></li>
<li><a class="dropdown-item" href="#" value="v2.2">Version 2.2</a></li>
Expand All @@ -46,7 +47,7 @@
})

// get the version from url
let version = 'v3.1';
let version = 'v4';
if (window.location.search && window.location.search.length > 1) {
const versionParams = window.location.search.slice(1).split("&").filter(function (item) {
return item.startsWith("version=")
Expand All @@ -60,6 +61,7 @@
}

const sopFileName = {
'v4': 'OncoKB_Curation_Standard_Operating_Procedure_v4.pdf',
'v3.1': 'OncoKB_Curation_Standard_Operating_Procedure_v3_1.pdf',
'v3': 'OncoKB_Curation_Standard_Operating_Procedure_v3.pdf',
'v3.0': 'OncoKB_Curation_Standard_Operating_Procedure_v3.pdf',
Expand Down
Binary file added sop/OncoKB_Curation_Standard_Operating_Procedure_v4.pdf
View file
Open in desktop
Binary file not shown.
Loading