Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_email uses production domains #26

Open
Ichimonji10 opened this issue Jul 1, 2014 · 3 comments
Open

generate_email uses production domains #26

Ichimonji10 opened this issue Jul 1, 2014 · 3 comments

Comments

@Ichimonji10
Copy link
Contributor

As described in RFC 2606, the IETF has reserved several domains for use within documentation and example code. The following top-level domains are reserved:

  • test
  • example
  • invalid
  • localhost

Additionally, the following second-level domains are reserved:

  • example.com
  • example.net
  • example.org

Method FauxFactory.generate_email should, by default, use these IETF-sanctioned domains.
@omaciel
Copy link
Owner

omaciel commented Jul 1, 2014

Sweet! I will try to get this baked in as soon as I can (unless you beat me to it) :)

@Ichimonji10
Copy link
Contributor Author

👍

@Ichimonji10
Copy link
Contributor Author

The same issue applies to generate_url.

omaciel added a commit that referenced this issue Jul 1, 2014
@omaciel
generate_email uses production domains.
57c3ab8 
This fixes issue #26.
@omaciel omaciel mentioned this issue Jul 1, 2014
Open
@Ichimonji10 Ichimonji10 mentioned this issue Sep 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omaciel @Ichimonji10