-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for showing/ hiding pins #164
base: master
Are you sure you want to change the base?
Conversation
added attribute for pin updated sample application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution but i think the solution is not scalable in this way rather i would suggest you update the mrb_temporaryPins
attribute from boolean
to enum
The following things you would need to add.
- Define an enum
PinDisplayProperties
having the valuesALWAYS,NEVER,ONLY_ON_TOUCH
- Add way to change
mrb_temporaryPins
from xml. - Add way to change
mrb_temporaryPins
from code. - Update the sample app accordingly so that we have the ability to see the different properties of
mrb_temporaryPins
@@ -32,6 +32,7 @@ | |||
<attr name="mrb_pinRadius" format="dimension"/> | |||
<attr name="mrb_connectingLineColors" format="reference"/> | |||
<attr name="mrb_onlyOnDrag" format="boolean"/> | |||
<attr name="mrb_pinsEnabled" format="boolean"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have a property mrb_temporaryPins
and i think this one should be changed so it should have the following three values
- ALWAYS (This displays them all the time)
- NEVER (This hides them all the time)
- ON_TOUCH_ONLY (This displays them when we are modifying the value and then hides them )
1 & 3 can be achieved right now by changing value for mrb_temporaryPins
to true
and false
but the 2nd one is what you have to implement and at the same time you need to change the mrb_temporaryPins
So at the end the mrb_temporaryPins
would be changed to something like this
<attr name="mrb_temporaryPins" format="enum">
<enum name="ALWAYS" value="0" />
<enum name="NEVER" value="1" />
<enum name="ON_TOUCH_ONLY" value="2" />
</attr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, I will add it
@svkaka can we have an ETA on the changes. I would like to release a new version in May and this could be added if the changes are done in time |
@svkaka Please resolve conflicts as well |
added attribute for the pin
updated sample application