Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling to a specific message using mhash key in query string does not work sometimes. #2430

Open
SebinSong opened this issue Nov 21, 2024 · 0 comments

Comments

@SebinSong
Copy link
Collaborator

SebinSong commented Nov 21, 2024

Problem

NOTE: it did work for Greg in GIG group but did not work when I tried the same message link on my MacOS and also when tried with the latest master locally, hence the word 'sometimes' in the title.

[Steps to reproduce]

  1. Create a group and go to the #general chatroom.
  2. Add some messages so the scrollbar appears.
  3. Copy one of the message link and try it.
  4. The chatroom page does appear but it does not auto-scroll to the target message (but rather scroll to the top) and mhash key in the query string disappears too.

Solution

Find out why this functionality has been lost and fix it.

@SebinSong SebinSong changed the title Scrolling to a specific message using mhash key in query string does not work sometimes Scrolling to a specific message using mhash key in query string does not work. Nov 21, 2024
@SebinSong SebinSong changed the title Scrolling to a specific message using mhash key in query string does not work. Scrolling to a specific message using mhash key in query string does not work sometimes. Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant