Fix inconsistency on env stderr output #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for env to produce output on stderr. `previous_env` did not capture stderr while `program_execution` does, so there would be spurious diffs when env outputs to stderr. This fixes that by capturing stderr in `previous_env` as well.
edlanglois
added a commit
to edlanglois/dotfiles
that referenced
this pull request
May 16, 2019
My fork fixes an issue when 'env' prints on stderr oh-my-fish/plugin-foreign-env#21 Switch back to the upstream master when the PR is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for env to produce output on stderr.
I don't know the precise condition, but it is triggered by the Environment Modules Bash initialization script
previous_envdid not capture stderr whileprogram_executiondoes,so there would be spurious diffs when env outputs to stderr.
This fixes that by capturing stderr in
previous_envas well.