Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from boost to pybind11 #12

Open
adler-j opened this issue Dec 14, 2015 · 8 comments
Open

Change from boost to pybind11 #12

adler-j opened this issue Dec 14, 2015 · 8 comments

Comments

@adler-j
Copy link
Member

adler-j commented Dec 14, 2015

PyBind11 is an alternative to boost python that does not require a compiled part (and the rest of boost), this would simplify compilation and distribution by PyPI.

@kohr-h
Copy link
Member

kohr-h commented Dec 14, 2015

Looks very nice indeed.

@adler-j
Copy link
Member Author

adler-j commented Dec 15, 2015

There is a branch for this out now. Compilation times are down drastically and we no longer need a boost dependency, instead we have PyBind11 as a submodule, but there are some issues. It does seem PyBind11 is actively maintained so they could be fixed soon.

EDIT: 5 tests still fail, one serious (index error not raised), and a few less serious (getitem returns a long in python 2).

@kohr-h
Copy link
Member

kohr-h commented Dec 15, 2015

Sounds great so far. I'm sure the errors can be fixed upstream.

@adler-j
Copy link
Member Author

adler-j commented Dec 15, 2015

Now 100% working, biggest (and really only) issue is that C++11 is not fully supported with VS2013, and CUDA does not work with VS2015. Currently, it works, so we can freeze at this commit of PyBind11 if we want, but if the author does some change that breaks VS2013, we cannot use that until CUDA catches up.

@kohr-h
Copy link
Member

kohr-h commented Dec 15, 2015

Ah these windows issues... Of course, we can freeze at the current state. When there is an upstream change, it's easy to just test and see if our systems cooperate with it.

@kohr-h
Copy link
Member

kohr-h commented Sep 30, 2016

I don't know if this conversation contains the latest issue which made us stall this, but now that CUDA 8 is out and VS15 support is there, perhaps it's time to reconsider?

@adler-j
Copy link
Member Author

adler-j commented Sep 30, 2016

It certainly is. I'll look more at it in a while.

@kohr-h
Copy link
Member

kohr-h commented Sep 30, 2016

As for now, CUDA 8 hasn't hit the mainstream Linux distro repos yet, so there's no need for a rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants