Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greedyMix() broken on GUI and FASTA datasets #8

Open
wleoncio opened this issue Aug 7, 2024 · 3 comments
Open

greedyMix() broken on GUI and FASTA datasets #8

wleoncio opened this issue Aug 7, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@wleoncio
Copy link
Member

wleoncio commented Aug 7, 2024

Reporting both because the solution may be identical.

Code to reproduce

baps("ExampleData/spatial clustering of individuals/Example data in FASTA format for clustering of haploid individuals.txt", "FASTA", "greedyMix")

Error message

Unknown file type
Output argument "processed_data" (and possibly others) not assigned a value in the execution with "process_data" function.

Error in greedyMix (line 18)
  tietue = process_data(tietue, file_type, partitionCompare);

Error in baps (line 36)
      greedyMix(file, file_type, partitionCompare);
@wleoncio wleoncio added the bug Something isn't working label Aug 7, 2024
@wleoncio wleoncio self-assigned this Aug 7, 2024
@wleoncio
Copy link
Member Author

wleoncio commented Aug 7, 2024

FASTA is not implemented for greedyMix() on the original code, but it is for spatial*Mixture(). Maybe drop support for it on the former (for now).

@wleoncio
Copy link
Member Author

wleoncio commented Aug 8, 2024

From Jukka:

yes it does [make sense to use FASTA files on greedyMix()]. Essentially the greedyMix model would only use variable positions (SNPs) in the fasta file and assumes all those SNPs are unlinked. So effectively it has the same effect as stripping all nonvariable columns from the input FASTA file and then proceeding with the remaining columns as if they were categorical variables as in the BAPS format.

Since the code for processing of these files is already in place (in other parts of the code), it looks worthwhile to repurpose the implementation and make sure BAPS and rBAPS outputs match.

wleoncio added a commit that referenced this issue Aug 8, 2024
Necessary so they can be used by functions on greedyMix()
wleoncio added a commit that referenced this issue Aug 8, 2024
wleoncio added a commit that referenced this issue Aug 8, 2024
wleoncio added a commit that referenced this issue Aug 26, 2024
* issue-8:
  Refactoring
  Processing coordinates from `baps()` call (#8)
  Replaced dialog windows with console inputs (#8)
  squash! Fixing potentially-unused variable
  Use filename from `baps()` when using FASTA on `greedyMix()` (#8)
@wleoncio
Copy link
Member Author

Regarding the idea of formatting FASTA as BAPS for processing on greedyMix(), Jukka wrote:

BAPS format is the easiest one to convert to, inside [the BAPS software] fasta is simply ripped into something akin BAPS formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant