Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Neck more generalizable #2417

Closed
shawntanzk opened this issue Apr 14, 2022 · 10 comments · Fixed by #3060
Closed

Make Neck more generalizable #2417

shawntanzk opened this issue Apr 14, 2022 · 10 comments · Fixed by #3060
Assignees

Comments

@shawntanzk
Copy link
Collaborator

Currently Fish cannot have a neck because of taxon constraints

@cmungall commented (#2367 (comment)):
"I think the best solution would be to generalize neck in a way that keeps
the fish people happy. Fish may lack a neck proper but they have an
analogous region of the craniocervucal region with the same skeletal
elements"

For now, we are making a taxon GCI (#2415) but a better solution is to make neck more generalizable like the above

I'm assigning myself for now so that it doesn't got unassigned, but I would like someone who is more knowledgeable about fish stuff to take over this ticket (not sure who, but if anyone knows, please do assign them/let me know)

@shawntanzk shawntanzk self-assigned this Apr 14, 2022
@cmungall
Copy link
Member

Cc @wdahdul

@wdahdul
Copy link
Member

wdahdul commented Jun 28, 2022

Thanks for copying me (and apologies for the delay!). The terms ‘neck’ or ‘craniocervical’ or ‘cervical’ aren’t used in the fish comparative literature for the region behind the skull, and as far as I know, there is no generalized term for that region in fish anatomy. For example, the vertebrae directly behind the head in fishes are called ‘precaudal vertebrae’ meaning that they are anterior to the caudal vertebrae.

@megbalk and I reviewed the related ticket and if the best option is a taxonomic constraint, we suggest using this: 'jugular vein' and ('in taxon' some Sarcopterygii) SubClassOf 'part of' some neck. In the related ticket, this was expressed at the level of Mammalia, but it can be broadened to Sarcopterygii (lobe finned fishes)– see the curator note on ‘neck’:

"true necks are considered to be present when the pectoral girdle is separate from the skull - Tiktaalik is the earliest known fish to have a true neck."

@cmungall
Copy link
Member

cmungall commented Jul 6, 2022

unfortunately tooling support for taxon GCIs are not great. This means people coming to OLS etc with mammals in mind looking under neck would not see jugular vein.

@shawntanzk
Copy link
Collaborator Author

@cmungall - could you suggest and actionable item for this please? thanks :)

@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Feb 19, 2023
@cmungall
Copy link
Member

cmungall commented Feb 20, 2023 via email

@github-actions github-actions bot removed the Stale label Feb 21, 2023
@anitacaron anitacaron assigned aleixpuigb and unassigned shawntanzk Feb 27, 2023
@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Aug 27, 2023
@anitacaron
Copy link
Collaborator

@aleixpuigb, can you try to work on this issue because we have a straightforward fix for it, please?

cmungall: generalize the existing taxon GCI from mammals to Sarcopterygii

change the taxon GCI here to Sarcopterygii in jugular vein (UBERON:0004711)

relationship: part_of UBERON:0000974 {gci_filler="NCBITaxon:40674", gci_relation="in_taxon"} ! neck

@github-actions github-actions bot removed the Stale label Sep 5, 2023
@aleixpuigb
Copy link
Collaborator

Looking at neck and the original ticket #2367, neck SubclassOf 'only in taxon' some Sarcopterygii doesn't seem correct, shouldn't we remove that axiom? Then we can add 'jugular vein' and ('in taxon' some Sarcopterygii) SubClassOf 'part of' some neck (not replacing the mammalian GCI). Therefore I suggest the following actions for this ticket:

  • Remove axiom neck SubclassOf 'only in taxon' some Sarcopterygii.
  • Add GCI 'jugular vein' and ('in taxon' some Sarcopterygii) SubClassOf 'part of' some neck.

@cmungall, do you agree with these edits?

@cmungall
Copy link
Member

cmungall commented Sep 7, 2023

agreed

aleixpuigb added a commit that referenced this issue Sep 7, 2023
Fixes #2417 make neck general
aleixpuigb added a commit that referenced this issue Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants