Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taxon constraints to FAO #13

Open
cmungall opened this issue Oct 19, 2016 · 8 comments
Open

Add taxon constraints to FAO #13

cmungall opened this issue Oct 19, 2016 · 8 comments
Assignees

Comments

@cmungall
Copy link
Member

cmungall commented Oct 19, 2016

See also geneontology/go-ontology#11313 (comment)

cc @thomaspd

@cmungall cmungall self-assigned this Oct 19, 2016
@dianeoinglis
Copy link

Is "only_in_fungi" the type of constraint you want to add?
How granular do you think these should be?
Some structures are not present in Ascomycetes, such as fused clamps which are structures made by Basidiomycetes, etc.

@cmungall
cc @thomaspc

@cmungall
Copy link
Member Author

For now I think high level distictions are best, at the Ascomycetes vs Basidiomycetes level seems good.

The main thing to be done is to do the initial plumbing so that you can add these. If you're working i oboedit this will take some futzing I'm afraid. Maybe we could explore keeping them in a separate file for now

@ValWood
Copy link

ValWood commented Nov 14, 2016

Yes it would be good to have "never in Ascomycetes" where possible so we can hide them from our community curators.
Cheers

Val

@dianeoinglis
Copy link

@cmungall
Currently, the FAO.obo does not have taxon constraints. Do you want the constraints in the FAO or in the xref'd GO term or both?

@cmungall
Copy link
Member Author

Ideally in the FAO, but this will take some work setting up as it involves imports. It's much easiest if all work is done in Protege thereafter. If that isn't a problem, I can make a pull request with the changes. (the source file can stay as .obo)

@dianeoinglis
Copy link

@cmungall
Could the goal of limiting the terms relevant to S. cerevisiae, etc be done as marked subsets as they are in the APO? For example, 'virulence' is marked as a Candida, Aspergillus and Cryptococcus subset so the cerevisiae curators never see the term, they only see terms in the S. cerevisiae subset. This seems cleaner and the majority of terms will not be in the Sc subset. I can't do the edits myself right now but I can work the specs out in the tracker. Right now there are about a dozen NTRs or modifications to make in addition to taxon limiters

@dianeoinglis
Copy link

@cmungall
I don't know why but the master file in GitHub is missing the [Typedef] is_a whereas it is present in the same file in OBO Foundry

@cmungall
Copy link
Member Author

cmungall commented Mar 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants