Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return codes on failures #507

Open
m-samoylov opened this issue Jul 6, 2017 · 0 comments
Open

Incorrect return codes on failures #507

m-samoylov opened this issue Jul 6, 2017 · 0 comments

Comments

@m-samoylov
Copy link

Versions of kyt, node, OS

kyt version: 0.5.2
node: 8.1.3

Bug or Feature?

Bug

Current Behavior

If command kyt build failed on loading kyt.config.js it exited with 0 return code. It breaks our CI system.

Desired Behavior

On failure return non-zero code.

kyt-core/utils/kytConfig.js:

catch (error) {
      logger.error('Error loading your kyt.config.js:', error);
      process.exit();
    }

Also, i found similar weirdnesses with return codes in this files:

cli/actions/proto.js:43
cli/actions/proto.js:57
utils/ifPortIsFreeDo.js:10
utils/ifPortIsFreeDo.js:18
utils/webpackCompiler.js:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant