fix(action): prevent collapse_dirs from trying to open file #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, opening a directory with one file with `collapse_dirs` set to true would result in the `open_dir` action trying to refresh the picker with that file as the new path. This caused `fd` to error out since a file isn't a valid folder. This was caused by a bad truthy check. Corrected this behavior to open folders regularly with `collapse_dirs` if the selected folder only contains one file. closes #348
jamestrew
force-pushed
the
348-bug-when-using-collapse_dirs-set-to-true
branch
from
1566e79
to
5fe5573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, opening a directory with one file with
collapse_dirsset to true would result in theopen_diraction trying to refresh the picker with that file as the new path. This causedfdto error out since a file isn't a valid folder. This was caused by a bad truthy check.Corrected this behavior to open folders regularly with
collapse_dirsif the selected folder only contains one file.closes #348