Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Changes #55

Open
fdschmidt93 opened this issue Jan 11, 2022 · 8 comments
Open

Breaking Changes #55

fdschmidt93 opened this issue Jan 11, 2022 · 8 comments

Comments

@fdschmidt93
Copy link
Member

This pinned issue is supposed to announce breaking changes (and possibly other critical info) to users.

The idea is that we announce (potentially) breaking changes hopefully with sufficient time (ideally weeks) in advance. Therefore, it is recommended to subscribe to the issue as means to keep informed about breaking news.

@fdschmidt93 fdschmidt93 added enhancement New feature or request and removed enhancement New feature or request labels Jan 11, 2022
@fdschmidt93 fdschmidt93 pinned this issue Jan 11, 2022
@fdschmidt93
Copy link
Member Author

fdschmidt93 commented Jan 11, 2022

#56 will change the logic of our mappings.

  • Remove the trailing _file of fb_actions.{create, rename, remove, move, open}_file to simplify and avoid confusion
  • Mappings prefixed with <A-KEY> correspond to file system operations, whereas <C-KEY> now relates to more picker specific actions

I realize that mappings are a very delicate and user-specific issue and sincerely apologize to every user who's had an annoyance over this breaking change.

telescope-file-browser maps as many as useful actions by default as possible for discoverability for novice and new users. I trust that experienced users can remap (docs) straightforwardly.

@nvim-telescope nvim-telescope locked and limited conversation to collaborators Jan 11, 2022
@fdschmidt93
Copy link
Member Author

The default mapping for going to the parent directory will change some time soon as per popular reddit requests (and /g are slowish).

Please watch out for #62

@fdschmidt93
Copy link
Member Author

fdschmidt93 commented Jan 13, 2022

I'm considering overhauling mappings once more. Please comment on #65 whether you prefer the current state of things over the proposal there or what you would like to see changed. Or just a thumbs up that you like the new mappings is also great.

I personally don't mind mappings but merely try to make the best default UX possible.

@fdschmidt93
Copy link
Member Author

fdschmidt93 commented Mar 25, 2022

#117 changed the behavior when hitting Enter in file browser mode with a prompt that yields no results. Now, it creates the file/folder and immediately opens it. So, in case the prompt is a

  • file: open the file in the current buffer
  • folder: open the folder with telescope-file-browser

The PR also has a quick showcase of the feature

@fdschmidt93
Copy link
Member Author

fdschmidt93 commented Apr 20, 2022

As per #124

The size and last changed date are now shown by default. Please see :h fb_picker.file_browser for more information.
The actions to sort by size or date are not yet mapped by default but users can do so via fb_actions.sort_by_{date, size}. I might add default mappings for them eventually.

Please let me know in case you have any issues (my testing was fine); I'll try to address them as swiftly as possible.

@fdschmidt93
Copy link
Member Author

As per #126

The docs are now more transparently and intuitively accessible via a dedicated module syntax.
In practice, fb_{actions, picker, finders}.$REF change to telescope-file-browser.{actions, picker, finders}.$REF when looking for the reference in help tags.

@fdschmidt93
Copy link
Member Author

If anyone is available to do so, I'd happily welcome some testers for #118 which I plan to merge on Sunday.

It should make the general UX of telescope-file-browser.nvim quite a lot nicer by smoothly avoiding hit-enter in most of situations in which it previously appeared.

@fdschmidt93
Copy link
Member Author

fdschmidt93 commented May 10, 2022

#118 will definitely be merged this week to finally get it over the line (plan: Friday). As mentioned before, it will make UX a lot smoother; however, there is a lot of cases to test and, while I did my best to cover all of them, there may be edge cases I haven't covered yet. Please link your package managers against current commit if you do not wish to update (or use packer snapshots).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant