Merge release 3.0.3 into 3.1.x #2263
core23continuous-integration.yml
on: pull_request
run
/
Generate test matrix
3s
Matrix: run / Code Coverage
Matrix: run / Coding Standards
Matrix: run / Lint composer.json
Matrix: run / Lint symfony container
Matrix: run / Mutation Tests
Matrix: run / Static Code Analysis
Matrix: run / Lint twig files
Matrix: run / Lint XLIFF files
Matrix: run / Lint YML files
Matrix: run / tests
Annotations
10 warnings
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L65
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
public function __invoke(Request $request) : Response
{
$event = new GetResponseLoginEvent($request);
- $this->eventDispatcher->dispatch($event, NucleosUserEvents::SECURITY_LOGIN_INITIALIZE);
+
if (null !== $event->getResponse()) {
return $event->getResponse();
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L72
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
if (null !== $event->getResponse()) {
return $event->getResponse();
}
- $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
+ $form = $this->formFactory->create(LoginFormType::class, null, ['method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L76
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
if (null !== $event->getResponse()) {
return $event->getResponse();
}
- $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
+ $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, []);
return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L83
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
return $event->getResponse();
}
$form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
- return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
+ return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' > $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L84
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
return $event->getResponse();
}
$form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
- return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
+ return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' > $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L85
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
return $event->getResponse();
}
$form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
- return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
+ return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' > $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/RequestResetAction.php#L85
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
if (null !== $response) {
return $response;
}
- $form = $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_request'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']);
+ $form = $this->formFactory->create(RequestPasswordFormType::class, null, ['method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']);
return new Response($this->twig->render('@NucleosUser/Resetting/request.html.twig', ['form' => $form->createView()]));
}
/**
|
|
run / Mutation Tests (8.2):
src/Action/RequestResetAction.php#L89
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
if (null !== $response) {
return $response;
}
- $form = $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_request'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']);
+ $form = $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_request'), 'method' => 'POST'])->add('save', SubmitType::class, []);
return new Response($this->twig->render('@NucleosUser/Resetting/request.html.twig', ['form' => $form->createView()]));
}
/**
|
|
run / Mutation Tests (8.2):
src/Action/RequestResetAction.php#L105
Escaped Mutant for Mutator "CastString":
--- Original
+++ New
@@ @@
*/
private function process(Request $request) : ?Response
{
- $username = (string) $request->request->get('username', '');
+ $username = $request->request->get('username', '');
if ('' === trim($username)) {
return null;
}
|
|
run / Mutation Tests (8.2):
src/Action/RequestResetAction.php#L107
Escaped Mutant for Mutator "UnwrapTrim":
--- Original
+++ New
@@ @@
private function process(Request $request) : ?Response
{
$username = (string) $request->request->get('username', '');
- if ('' === trim($username)) {
+ if ('' === $username) {
return null;
}
$user = null;
|