Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better summary plot for lightcurve-analysis #365

Merged

Conversation

tsunhopang
Copy link
Collaborator

Updating the best fit plots to be more informative.

Example plots can be found at https://enlil.gw.physik.uni-potsdam.de/~ppang/Bu2023Ye_uniform_lightcurves/

The best-fit plots are created per filter, and the chi2 per data point is plotted with the total chi2 shown in the title.

@tsunhopang tsunhopang requested a review from mcoughlin July 4, 2024 10:23
@tsunhopang tsunhopang added the enhancement New feature or request label Jul 4, 2024
@mcoughlin
Copy link
Member

@tsunhopang these are looking better. Are we still going to have a single plot where all of these are shown in one panel, as you would want to show on a website or even a paper?

@tsunhopang
Copy link
Collaborator Author

@mcoughlin I am a bit indecisive about this. For publications, we always have to remake the plots for styling, etc. And for diagnosis, it is better to have a detailed look at each panel. However, I think having a summary HTML is a good middle ground. Lemme work on that.

@mcoughlin
Copy link
Member

@Theodlz i am wondering what might work best for us, given desire for a display in SkyPortal. Could we handle multiple figures?

@tsunhopang We have benefited from the nice representation sncosmo has for the light curve fits, that single panel is very effective at showing fit quality in one look.

@tsunhopang
Copy link
Collaborator Author

@mcoughlin I see, lemme combine the plots then

@mcoughlin
Copy link
Member

@tsunhopang did you end up combining the plots?

@tsunhopang
Copy link
Collaborator Author

I am still working on the geometry of the figure

@mcoughlin
Copy link
Member

@tsunhopang any luck?

@tsunhopang
Copy link
Collaborator Author

@mcoughlin , what do you think about this figure? If all good, I will clean up the code a bit and merge it

image

@mcoughlin
Copy link
Member

@tsunhopang beautiful.

@tsunhopang tsunhopang self-assigned this Jul 18, 2024
@tsunhopang
Copy link
Collaborator Author

@mcoughlin could you approve it?

Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoughlin mcoughlin merged commit 904ec5b into nuclear-multimessenger-astronomy:main Jul 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants