-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better summary plot for lightcurve-analysis #365
Better summary plot for lightcurve-analysis #365
Conversation
@tsunhopang these are looking better. Are we still going to have a single plot where all of these are shown in one panel, as you would want to show on a website or even a paper? |
@mcoughlin I am a bit indecisive about this. For publications, we always have to remake the plots for styling, etc. And for diagnosis, it is better to have a detailed look at each panel. However, I think having a summary HTML is a good middle ground. Lemme work on that. |
@Theodlz i am wondering what might work best for us, given desire for a display in SkyPortal. Could we handle multiple figures? @tsunhopang We have benefited from the nice representation sncosmo has for the light curve fits, that single panel is very effective at showing fit quality in one look. |
@mcoughlin I see, lemme combine the plots then |
@tsunhopang did you end up combining the plots? |
I am still working on the geometry of the figure |
@tsunhopang any luck? |
@mcoughlin , what do you think about this figure? If all good, I will clean up the code a bit and merge it |
@tsunhopang beautiful. |
@mcoughlin could you approve it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
904ec5b
into
nuclear-multimessenger-astronomy:main
Updating the best fit plots to be more informative.
Example plots can be found at https://enlil.gw.physik.uni-potsdam.de/~ppang/Bu2023Ye_uniform_lightcurves/
The best-fit plots are created per filter, and the chi2 per data point is plotted with the total chi2 shown in the title.