Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for EM Counterpart Detection and Bandpass Interpolation (sncosmo) #305

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

weizmannk
Copy link
Collaborator

This pull request is designed to address and introduce certain processes:

  1. Bilby Integration with gpstime:

    • The process now utilizes gpstime provided in the injections.dat file for enhanced accuracy.
  2. Integration of snscosmo _BANDPASS_INTERPOLATORS:

    • Added functionality to retrieve bandpass interpolators, with support for the 'ultrasat' filter. This enhancement extends the capabilities of our bandpass interpolation.
  3. Revamp of EM Counterpart Detection in gwemopt:

    • The detection process for Electromagnetic (EM) counterparts has been restructured. This update is focused on incorporating a range of telescopes including ULTRASAT, LSST, ZTF, and others specified in the gwemopt config file.
    • Default proxy filters are set as follows:
      • 'ultrasat' band for ULTRASAT (noting that 'ultrasat' is the only filter of ULTRASAT )
      • 'ps1__r' band for LSST.
      • 'ztfr' band for ZTF.
    • For telescopes other than ULTRASAT, LSST, and ZTF, users are required to specify the proxy band.

Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoughlin mcoughlin merged commit 2b4f9b7 into nuclear-multimessenger-astronomy:main Jan 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants