Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZTF23aaxeacr lightcurve to example_files #282

Merged

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Dec 1, 2023

This PR adds the lightcurve for ZTF23aaxeacr to example_files/candidate_data. This lightcurve contains ZTF and SDSS magnitudes.

@mcoughlin
Copy link
Member

@bfhealy Looks like we have some duplicates in the list. Maybe we can clean it a bit? Might imply we also might want to clean the inputs coming out of SP (perhaps this is alert and FP @Theodlz?).

Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfhealy
Copy link
Collaborator Author

bfhealy commented Dec 1, 2023

@mcoughlin @Theodlz Looks like there is indeed forced photometry for this source in addition to alert photometry. I can open a quick PR to nmma-api to keep only the first of duplicate points unless we want to take a more specific approach than that.

@mcoughlin
Copy link
Member

Sounds good!

@bfhealy bfhealy merged commit 1648265 into nuclear-multimessenger-astronomy:main Dec 4, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants