Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinning GRB parameters #228

Merged
merged 5 commits into from
Sep 8, 2023
Merged

pinning GRB parameters #228

merged 5 commits into from
Sep 8, 2023

Conversation

sahiljhawar
Copy link
Member

pinning GRB parameters to avoid empty light curves error

mcoughlin
mcoughlin requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, should just change the parameter name.

nmma/tests/injections.py Outdated Show resolved Hide resolved
@mcoughlin mcoughlin self-requested a review September 8, 2023 20:20
mcoughlin
mcoughlin approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoughlin mcoughlin merged commit ad3d1e1 into nuclear-multimessenger-astronomy:main Sep 8, 2023
5 checks passed
@sahiljhawar sahiljhawar deleted the GRB_model_pin branch January 25, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoughlin mcoughlin mcoughlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahiljhawar @mcoughlin