remove react-hot-loader #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@captainsafia // silly ping. if you have any comment about this, let me know :) |
|
@beingbook Seeing this now. Was OOF for a bit. This looks fine to merge. |
captainsafia
approved these changes
Jul 29, 2020
|
Not to self: we need to ship a patch release of this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nteract.slack.com/archives/C0HSD7MMZ/p1595493976323500
react-hot-loaderdep breaks React warning systems.The errors in the screenshot are false warnings.
It creates too much IO, so the development environment gets slow.
so I just removed the use-cases. And nteract application looks not use react-hot-loader anymore.