Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multipass] Clear up API #70

Open
Ninigi opened this issue Apr 5, 2019 · 1 comment
Open

[Multipass] Clear up API #70

Ninigi opened this issue Apr 5, 2019 · 1 comment
Labels
enhancement good first issue Easy to fix issue, does not need a lot of experience to be able to contribute help wanted

Comments

@Ninigi
Copy link
Collaborator

Ninigi commented Apr 5, 2019

For testability, the author of the original PR #65 made all functions public. In order to clear up which part is meant as the public API, we should:

either make the majority of the functions private, which would lose the ability to test them

or

add @doc false to non public-API functions
@Ninigi Ninigi added enhancement good first issue Easy to fix issue, does not need a lot of experience to be able to contribute help wanted labels Apr 12, 2019
@hasitha
Copy link

hasitha commented Dec 4, 2019

How about extracting them to a separate module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Easy to fix issue, does not need a lot of experience to be able to contribute help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hasitha @Ninigi