You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seems like there's no error handling for when a file is not parsable. (It just crashes with struct.error: unpack requires a buffer of 12 bytes.) Probably would be more useful to raise an exception if the file is determined to be no good?
I'm building out an application that uses this library, and I'm trying to validate that the file is parsed correctly, and it seems a little wonky to handle it by catching this struct.error.
The text was updated successfully, but these errors were encountered:
Hi sorry I did not see this as my emails are usually flooded with other github notices, this one slipped through. @quarklark do you have some feelings about the nature of the exception (or even just how exception handling should be addressed here? I’m happy to collaborate or let you take the reigns on a pr if you have strong feelings) hope alls well and sorry for the delay
Seems like there's no error handling for when a file is not parsable. (It just crashes with
struct.error: unpack requires a buffer of 12 bytes
.) Probably would be more useful to raise an exception if the file is determined to be no good?I'm building out an application that uses this library, and I'm trying to validate that the file is parsed correctly, and it seems a little wonky to handle it by catching this
struct.error
.The text was updated successfully, but these errors were encountered: