Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adr-tools doesn't work correctly in git bash because more is missing #68

Closed
andrew-schofield opened this issue Sep 14, 2018 · 4 comments

Comments

@andrew-schofield
Copy link

The linux toolset included with git bash is missing more which means that adr help (f.e.) doesn't work.
git bash does have less which works just as well, so my initial workaround was to copy less.exe to more.exe in the git bash usr/bin/ folder.

Is there a technical reason why adr-tools uses more rather than less? Could it be changed without breaking other platforms?

I can submit a PR with an updated INSTALL.md which includes a note about copying less to more, or I can submit a PR with the shell script change to use less instead of more.

@retnuh
Copy link

retnuh commented Sep 14, 2018 via email

@npryce
Copy link
Owner

npryce commented Sep 16, 2018

Adr-tools does use $PAGER. It also uses $ADR_PAGER if (for some reason) you want a different pager for adr-tools than your default. It falls back to more because that is defined by POSIX, and less is not. If you want to use less, set either PAGER or ADR_PAGER to less.

@npryce npryce closed this as completed Sep 16, 2018
@andrew-schofield
Copy link
Author

In that case the install instructions for git bash do need updating, as it neither defines $PAGER nor has the POSIX compliant more

@npryce
Copy link
Owner

npryce commented Sep 16, 2018

Yes. See #69 (contributions welcome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants