Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ 17 and boost filesystem #587

Closed
sloriot opened this issue Sep 17, 2024 · 2 comments
Closed

C++ 17 and boost filesystem #587

sloriot opened this issue Sep 17, 2024 · 2 comments

Comments

@sloriot
Copy link
Contributor

sloriot commented Sep 17, 2024

Hi,

I see in some CMakeLists that you require c++17. If that's the case, would you accept a PR that replaces boost filesystem with the filesystem of the STL?

@boxanm
Copy link
Collaborator

boxanm commented Sep 17, 2024

Hello @sloriot and thanks for the offer!
We already replaced boost::filesystem in the develop branch, see this PR: #581. There were some instabilities on our build server so it hasn't been merged to master yet. I believe they were fixed, so you can expect a new release of libpointmatcher later this week.

@sloriot
Copy link
Contributor Author

sloriot commented Sep 17, 2024

Oh that's great, Thanks! I'll close the issue.

PS: I did try the develop branch @f42ea4ba7525646a9f2a2d723d341a2515fc6084 and it seems that something changed in the cmake magic. AFAIR, I could use it directly from the build dir but ${libpointmatcher_INCLUDE_DIRS} only contains eigen path and not libpointmatcher include path. Trying make install does not help as it complains that it can't find libpointmatcher-config.cmake (wasn't copied most probably).

@sloriot sloriot closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants