Ticket linking of items allows items that do not exist

[jasonpagetas]

When linking an item to a ticket I accidentally selected services instead of software, I entered the id of the software I wanted in this case 16.

Now in the linked items it shows $service-16

This should throw an error as the id does not exist

[jon-nfc]

Now in the linked items it shows $service-16

where?

so did the item link or is this in a comment

[jon-nfc]

agreed this should not occur.

[jon-nfc]

TBH I don't know how this bug is even possible Using a scenario of linking a non-existing item.

The logic was setup purposely to to try and fetch the item by the id provided in the command, if the item does not exist an exception is thrown which prevents linking the item to the ticket.

centurion_erp/app/core/lib/slash_commands/linked_model.py

Lines 129 to 146 in dfdc5ba

	if model:
	item = model.objects.get(
	pk = model_id
	)
	TicketLinkedItem.objects.create(
	organization = self.organization,
	ticket = ticket,
	item_type = item_type,
	item = item.id
	)
	return None
	except Exception as e:
	return str(match.string[match.start():match.end()])

The above code has not changed since it was initially introduced.

The only way i see this occurring is the item was linked and later removed. This scenario will create what you have reported.

Within the current test env (v1.3.0) I can't link an item that does not exist.

Test cases have been added in e9d5b08 to ensure that there is no regression in the requirement, dont link non-existing item to ticket

I'm going to assume that what has occured is that the item was linked when it was created, then subsequently deleted. I will add some test cases to ensure that when an item is deleted, the linking to tickets is also cleaned up.

[jon-nfc]

Added fix in dc55883 to correct the issue where when an item that may be linked to a ticket is deleted, the ticket link is also removed.

Test Cases added in e170226 to ensure there is no regression in the requirement "when an item is deleted, remove the ticket link".

This issue will be resolved on release of #344.