Add contribute link to navbar #7274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- apps/site/navigation.json: Language not supported
- packages/i18n/locales/en.json: Language not supported
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikeesto
approved these changes
Nov 22, 2024
AugustinMauroy
approved these changes
Nov 22, 2024
ovflowd
reviewed
Nov 23, 2024
|
todo: we also need a redirect |
aymen94
approved these changes
Nov 25, 2024
|
@joyeecheung this was your original idea. we now have:
can you think of anything else? |
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does the simplest thing we can to improve visibility of contribution, while avoiding some of the problems we encountered with the version support docs.
As @joyeecheung accurately points out, directly linking to this content is the best way to keep it up to date.
Open to iteration, but I wanted to advance the conversation with a concrete implementation.
Validation
See the preview build
Related Issues
closes #7237
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.