-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated, scheduled crowdin sync #7272
Open
bmuenzenmeyer
wants to merge
9
commits into
main
Choose a base branch
from
crowdin-gh-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+108
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
bmuenzenmeyer
force-pushed
the
crowdin-gh-action
branch
from
November 21, 2024 16:33
7dbeb77
to
3ee0588
Compare
bmuenzenmeyer
force-pushed
the
crowdin-gh-action
branch
from
November 21, 2024 17:13
3ee0588
to
1f17c61
Compare
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Nov 21, 2024
Contributor
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 suggestion.
Lighthouse Results
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Nov 21, 2024
RedYetiDev
approved these changes
Nov 21, 2024
bjohansebas
reviewed
Nov 21, 2024
bmuenzenmeyer
commented
Nov 21, 2024
@nodejs/web-infra one last pass on this would be appreciated |
mikeesto
reviewed
Nov 23, 2024
Co-authored-by: Michael Esteban <mickel13@gmail.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces an automated way to initiate crowdin syncs.
In talking with the crowdin team, this seemed to be the logical next step.
Note that this does not replace our existing workflow, which:
Validation
Related Issues
#7121
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.