Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow http2 server to be configured with ALPNCallback #55994

Open
Y3RmKHgp opened this issue Nov 25, 2024 · 0 comments
Open

Allow http2 server to be configured with ALPNCallback #55994

Y3RmKHgp opened this issue Nov 25, 2024 · 0 comments
Labels
feature request Issues that request new features to be added to Node.js. http2 Issues or PRs related to the http2 subsystem.

Comments

@Y3RmKHgp
Copy link

What is the problem this feature will solve?

Currently, the http2 server always sets the ALPNProtocols field on the TLSServer options, which makes it incompatible with the ALPNCallback option.

Fixing this allows an http2 server with custom ALPN processing to be possible. For example, this allows the server to dynamically allow or deny http2 support based on the SNI.

What is the feature you are proposing to solve the problem?

Patch lib/internal/http2/core.js to avoid setting ALPNProtocols if ALPNCallback is present.

What alternatives have you considered?

No response

@Y3RmKHgp Y3RmKHgp added the feature request Issues that request new features to be added to Node.js. label Nov 25, 2024
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Node.js feature requests Nov 25, 2024
@jazelly jazelly added the http2 Issues or PRs related to the http2 subsystem. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. http2 Issues or PRs related to the http2 subsystem.
Projects
Status: Awaiting Triage
Development

No branches or pull requests

2 participants