-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript rewrite #174
Comments
On hold until we have discussed this. |
Is this something that is still being considered? As a sub part of the migration to typescript, have you considered changing to use ECMAScript modules (esm)? |
Hi @lohart13 we definitely consider Typescript in the long run. Regarding esm, I'm not sure if it's beneficial, since it's one more rewrite and I would like to avoid a hard dependency to a specific bundler. |
Ok, I have recently written a similar version of oauth2-server in typescript for another project, do you want me to submit this as a PR? Out of interest, would this be in scope for v5 or a future release? |
@lohart13 thanks but we currently have a pending PR for a TS rewrite but it's blocked since at least I still have not enough typescript skills to do a sufficient review. However, this is definitely on my agenda as it's required for another project, too. Maybe you could take a look into the pending TS rewrite PR and leave some comments. |
A TypeScript rewrite is definitely on the roadmap. This would be in the scope of v5 since we are converting a lot of stuff to ES6+ see #212 We'll be accepting PR's after v5 has been published. Closing for now. |
I'm currently rewriting this in TypeScript, and I will submit a PR when I'm done. I think that a TypeScript rewrite would be a great step in stability and dev-experience, since it would support generics, inheritance, and a bunch more features. (Goodbye,
util.inherits()
!)This would solve:
The text was updated successfully, but these errors were encountered: