Exception chaining #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a query in the db server, and therefore failing to cancel the original query
…se operations, not on queued operations.
…rmittently. Timer.purge() is linear in the number of TimerTasks, and is synchronized on the Timer's monitor, so calling purge() for every task was effectively quadratic. This can get bad if load causes many taks to get backed up on the Timer.
…eue intermittently." On further inspection, we don't need to call purge() at all. We'll revert this, and remove the call to purge in a future change. This reverts commit 576bda7.
…run their timeout. We were calling it for every task, and it's linear in the number of tasks, and synchronized on the timer's monitor, so it was effectively quadratic on the number of pending tasks. It turns out that we don't need to call purge() at all anyway...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is specifically to address the issue of exception chaining in SqlQuery. The fix passes the original exception along as a cause.
Added spec to test that the underlying cause is indeed propagated.