Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Mac OS #18

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add support for Mac OS #18

wants to merge 4 commits into from

Commits on Aug 6, 2023

  1. Revert "github: Remove workflow for Mac OS X" 

    This reverts commit c945f58.

I initially removed the workflow because it was failing all the time and
always seeing commit messages with failed CI checks is not only pretty
unhelpful but we might miss other *relevant* failures because of that.

So this brings back the workflow for Darwin since we're now actually
working on at least trying to implement support for it.

The reason why I'm not adding this *after* adding support is that I
don't have a Mac OS X machine, so I have to purely relying on the GitHub
Actions workflow.

Signed-off-by: aszlig <aszlig@nix.build>
    @aszlig
    aszlig committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    3790608 View commit details
    Browse the repository at this point in the history

  2. darwin: Use LOCAL_PEERCRED instead of SO_PEERCRED 

    While LOCAL_PEERCRED is somewhat similar to SO_PEERCRED, we
unfortunately don't have access to the PID of the remote peer.

This is something we actually need to properly distinguish the remote
peer by giving it an IP address with the PID encoded, otherwise we'd end
up with duplicate IPs.

On the other hand, using random IP addresses also is not a very good
solution here, since we actually *want* to have the same IP for the same
process.

Right now the UID and GID fields are not used at all on Darwin, but we
really need to figure out a way to properly assign fake IP addresses.

Signed-off-by: aszlig <aszlig@nix.build>
    @aszlig
    aszlig committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    3581ecb View commit details
    Browse the repository at this point in the history

  3. github: Add pytest to macos workflow 

    This is needed in order to run integration tests, which we certainly
want to run on Darwin, because I do not have a single machine running
MacOS and thus for me the only way to check whether something is broken
is by checking whether the integration tests have failed.

Signed-off-by: aszlig <aszlig@nix.build>
    @aszlig
    aszlig committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    714d2a8 View commit details
    Browse the repository at this point in the history

  4. fixup! Revert "github: Remove workflow for Mac OS X"

    @aszlig
    aszlig committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    a4efd83 View commit details
    Browse the repository at this point in the history