Support additional format search paths #148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomeon
force-pushed
the
format-search-path-extension
branch
4 times, most recently
from
f9cc15d
to
547da9e
Compare
|
I actually don't have any tests right now for this :D I don't use the gitlab-ci setup. I don't know if building all images on the github worker is feasible. But for the start, I guess a test command somewhere which builds all images would be a nice thing to have? But that is not really a blocker for this PR I guess (except if you want to do it ;) ) |
via the NIXOS_GENERATORS_FORMAT_SEARCH_PATH environment variable and --format-search-path CLI option. Additionally, introduce the --show-format-search-path option, which causes nixos-generate to print the list of paths it will search for format files.
tomeon
force-pushed
the
format-search-path-extension
branch
from
547da9e
to
651616b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via the
NIXOS_GENERATORS_FORMAT_SEARCH_PATHenvironment variable and--format-search-pathCLI option, as proposed in #147.Additionally, introduce the
--show-format-search-pathoption, which causesnixos-generateto print the list of paths it will search for format files.Marked as a draft because:
nixos-generate(a) rejects bad format names, (b) prints the expected paths when called with--show-format-search-path, (c) prints formats from additional search paths when called with--list, etc.Thanks!