Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip attrsets in patterns #130

Merged
merged 1 commit into from
Aug 25, 2024
Merged

fix: skip attrsets in patterns #130

merged 1 commit into from
Aug 25, 2024

Conversation

fgaz
Copy link
Contributor

@fgaz fgaz commented Aug 21, 2024

Fixes parsing of docs in this kind of code:

{ 
  pkgs ? import <nixpkgs>
    # | This attrset must be skipped -- it is not the top-level attrset
    # ↓ even though it comes first!
    {   }
}:

{
  /** 
    This binding is in the top-level attrset
  */
  iAmTopLevel = null;
}

@fgaz fgaz changed the title fix: attrsets in patterns should not be considered fix: skip attrsets in patterns Aug 21, 2024
Copy link
Collaborator

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for writing the test and giving a nice explanation of the problem!

@infinisil infinisil merged commit 203aa64 into nix-community:master Aug 25, 2024
2 checks passed
@fgaz fgaz deleted the skip-patterns branch August 25, 2024 09:29
@fgaz
Copy link
Contributor Author

fgaz commented Sep 5, 2024

@infinisil could you tag a new release so we get the fix in nixpkgs?

@infinisil
Copy link
Collaborator

@hsjobeki Could you do the release?

@fgaz
Copy link
Contributor Author

fgaz commented Sep 5, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants