Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename s variable to curr_seqinfo in reproin heuristic #779

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 8, 2024

This stems from #770.

Changes proposed:

  • Rename the s variable to curr_seqinfo in the ReproIn heuristic, for readability.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.08%. Comparing base (1d98617) to head (fd06d83).
Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
heudiconv/heuristics/reproin.py 87.50% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files          42       42           
  Lines        4215     4215           
=======================================
  Hits         3460     3460           
  Misses        755      755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic added the internal Changes only affect the internal API label Aug 8, 2024
@yarikoptic yarikoptic merged commit a0a3635 into nipy:master Aug 8, 2024
9 checks passed
@tsalo tsalo deleted the s-to-curr-seqinfo branch August 8, 2024 20:31
Copy link

🚀 PR was released in v1.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants