You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
returnnewEconomyResponse(0, account.balance(), ResponseType.FAILURE, LANG
.plugin_vault_insufficientSpace);
I would submit a PR, but what is the correct Vault approach here?
Should amount be the actual deposited amount, or the remaining amount (which could not be deposited)?
Also is ResponseType.FAILURE correct in this case?
This line seems to be incorrect, since amount is simply set to 0, but some funds may have been deposited:
gringotts/src/main/java/org/gestern/gringotts/api/impl/VaultConnector.java
Lines 161 to 163 in f7ade10
I would submit a PR, but what is the correct Vault approach here?
Should amount be the actual deposited amount, or the remaining amount (which could not be deposited)?
Also is
ResponseType.FAILURE
correct in this case?The vault documentation is not really helpful here:
http://milkbowl.github.io/VaultAPI/net/milkbowl/vault/economy/EconomyResponse.html#amount
http://milkbowl.github.io/VaultAPI/net/milkbowl/vault/economy/EconomyResponse.html#type
The text was updated successfully, but these errors were encountered: