Merge KhronoGroup/OpenCL-CTS: main into nikhiljnv/OpenCL-CTS:KhronosGroup-master #43

* Fix enqueue_flags test to use correct barrier type. Currently, enqueue_flags test uses CLK_LOCAL_MEM_FENCE. Use CLK_GLOBAL_MEM_FENCE instead as all threads across work-groups need to wait here. * Add check for support for Read-Wrie images Read-Write images have required OpenCL 2.x. Read-Write image tests are already being skipped for 1.x devices. With OpenCL 3.0, read-write images being optional, the tests should be run or skipped depending on the implementation support. Add a check to decide if Read-Write images are supported or required to be supported depending on OpenCL version and decide if the tests should be run on skipped. Fixes issue #894 * Fix formatting in case of Read-Write image checks. Fix formatting in case of Read-write image checks. Also, combine two ifs into one in case of kerne_read_write tests * Fix some more formatting for RW-image checks Remove unnecessary spaces at various places. Also, fix lengthy lines. * Fix malloc-size calculation in test imagedim unsigned char size is silently assumed to be 1 in imagedim test of test_basic. Pass sizeof(type) in malloc size calculation. Also, change loop variable from signed to unsigned. Add checks for null pointer for malloced memory. * Initial CTS for external sharing extensions Initial set of tests for below extensions with Vulkan as producer 1. cl_khr_external_memory 2. cl_khr_external_memory_win32 3. cl_khr_external_memory_opaque_fd 4. cl_khr_external_semaphore 5. cl_khr_external_semaphore_win32 6. cl_khr_external_semaphore_opaque_fd * Updates to external sharing CTS Updates to external sharing CTS 1. Fix some build issues to remove unnecessary, non-existent files 2. Add new tests for platform and device queries. 3. Some added checks for VK Support. * Update CTS build script for Vulkan Headers Update CTS build to clone Vulkan Headers repo and pass it to CTS build in preparation for external memory and semaphore tests * Fix Vulkan header path Fix Vulkan header include path. * Add Vulkan loader dependency Vulkan loader is required to build test_vulkan of OpenCL-CTS. Clone and build Vulkan loader as prerequisite to OpenCL-CTS. * Fix Vulkan loader path in test_vulkan Remove arch/os suffix in Vulkan loader path to match vulkan loader repo build. * Fix warnings around getHandle API. Return type of getHandle is defined differently based on win or linux builds. Use appropriate guards when using API at other places. While at it remove duplicate definition of ARRAY_SIZE. * Use ARRAY_SIZE in harness. Use already defined ARRAY_SIZE macro from test_harness. * Fix build issues for test_vulkan Fix build issues for test_vulkan 1. Add cl_ext.h in common files 2. Replace cl_mem_properties_khr with cl_mem_properties 3. Replace cl_external_mem_handle_type_khr with cl_external_memory_handle_type_khr 4. Type-cast malloc as required. * Fix code formatting. Fix code formatting to get CTS CI builds clean. * Fix formatting fixes part-2 Another set of formatting fixes. * Fix code formatting part-3 Some more code formatting fixes. * Fix code formatting issues part-4 More code formatting fixes. * Formatting fixes part-5 Some more formatting fixes * Fix formatting part-6 More formatting fixes continued. * Code formatting fixes part-7 Code formatting fixes for image * Code formatting fixes part-8 Fixes for platform and device query tests. * Code formatting fixes part-9 More formatting fixes for vulkan_wrapper * Code formatting fixes part-10 More fixes to wrapper header * Code formatting fixes part-11 Formatting fixes for api_list * Code formatting fixes part-12 Formatting fixes for api_list_map. * Code formatting changes part-13 Code formatting changes for utility. * Code formatting fixes part-15 Formatting fixes for wrapper. * Misc Code formatting fixes Some more misc code formatting fixes. * Fix build breaks due to code formatting Fix build issues arised with recent code formatting issues. * Fix presubmit script after merge Fix presubmit script after merge conflicts. * Fix Vulkan loader build in presubmit script. Use cmake ninja and appropriate toolchain for Vulkan loader dependency to fix linking issue on arm/aarch64. * Use static array sizes Use static array sizes to fix windows builds. * Some left-out formatting fixes. Fix remaining formatting issues. * Fix harness header path Fix harness header path While at it, remove Misc and test pragma. * Add/Fix license information Add Khronos License info for test_vulkan. Replace Apple license with Khronos as applicable. * Fix headers for Mac OSX builds. Use appropriate headers for Mac OSX builds * Fix Mac OSX builds. Use appropriate headers for Mac OSX builds. Also, fix some build issues due to type-casting. * Fix new code formatting issues Fix new code formatting issues with recent MacOS fixes. * Add back missing case statement Add back missing case statement that was accidentally removed. * Disable USE_GAS for Vulkan Loader build. Disable USE_GAS for Vulkan Loader build to fix aarch64 build. * Fixes to OpenCL external sharing tests Fix clReleaseSemaphore() API. Fix copyright year. Some other minor fixes. * Improvements to OpenCL external sharing CTS Use SPIR-V shaders instead of NV extension path from GLSL to Vulkan shaders. Fixes for lower end GPUs to use limited memory. Update copy-right year at some more places. * Fix new code formatting issues. Fix code formatting issues with recent changes for external sharing tests. * More formatting fixes. More formatting fixes for recent updates to external sharing tests. * Final code formatting fixes. Minor formatting fixes to get format checks clean. * Update extension list of test_compiler Upate extension list of test_compiler with missing external memory and semaphore extensions * Add ffp-contract=off Compilation flag for CTS build. GCC defaults to using ffp-contract=fast even when fast math is disabled in the case of GNU C This creates precision issues when comparing the results with that of x86_64. GNU options reference: https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html# This fix is to disable floating-point expression contractions with flag ffp-contract=off for math_brute_force tests Fixes #1794 * Make fp-contract flag arch-independent, but compiler dependent Use existing CMake constructs to add fp-contract flag so that it automatically checks for compiler support. Also, make this change arch-independent. Fixes #1794 * Fix typo in earlier commit Fix typo in earlier commit Fixes #1794 * Remove duplicate addition of ffp-contract flag ffp-contract flag is currently added via two macros Retain add_cxx_flag_if_supported macro and remove set_gnulike_module_compile_flags. Fixes #1794 * Fix typo in earlier commit Add closing " that was unintentionally removed in previous commit.

* add tests for clCommandSVMMemcpyKHR & clCommandSVMMemfillKHR * Fix typo SVMMemfill -> SVMMemFill * fix clCommandSVMMemFillKHR calls to match extension * add Khronos license + minor fixes * review fixes

The spec requires implementations return NULL for CL_MEM_HOST_PTR when the flags passed at memory object creation time do not contain CL_MEM_USE_HOST_PTR CTS was not checking this. Add the same check. Fixes #1752

…1713) * Added cl_khr_fp16 support for test_explicit_s2v from basic (issue #142, basic) * Cosmetic corrections * cosmetic fix * Added correction to distinguish signed and unsigned char types for ARM architecture tests * Added missing pieces of convertion procedure to support half * Corrected condition to verify if additional pragma is necessary (issue #142, basic) * Add NaN check for half to float conversion * check-format fixes * Add NaN check for all float types Use std::isnan for float/double types. Change-Id: I005bddccaa3f8490ac59b2aa431ed315733ad143 * Fix Ubuntu build error with isnan macro definition Change-Id: I671ed826a9631fbbc66d0aa9b674ab00124c7967 * Check format fixes * NAN define not needed anymore --------- Co-authored-by: Vasu Penugonda <vpenugon@qti.qualcomm.com> Co-authored-by: Sreelakshmi Haridas <sharidas@quicinc.com>

This is helpful for testing progvars on implementations not implementing all the optional atomic features.

Remove left over file from (#1537) #1537 (comment) Signed-off-by: John Kesapides <john.kesapides@arm.com>

Only check against 2D image types as per the spec. Move some device checks out of the loop. Only perform the checks when element_size is a power of two. Signed-off-by: John Kesapides <john.kesapides@arm.com>

Initialize the `_memoryOrder` and `_memoryScope` members to avoid `CBasicTestMemOrderScope::MaxHostThreads()` accessing uninitialized data. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Some `HOST_` types were declared with signedness different from the `HOST_ATOMIC_` counterparts, leading to sign-compare warnings when comparing between types. Fix by aligning the signedness. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Using `local_size_x = 512` in the shader used in the Vulkan interop tests fails on older hardware because this exceeds the maximum barrier size limit. Changed to 256, which is still a multiple of 32 and 64, and is below the hardware limitations. The tests are not performance tests anyways, so the performance penalty, if any, is acceptable. Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>

…1814) * switch to the new memory and semaphore specific device handle lists * remove support for older headers * dummy commit

Vulkan guarantees 128 is always supported. Relates to #1828 Signed-off-by: Kevin Petit <kevin.petit@arm.com>

* Added support for SYNC_FD and other handle types * Fix consistency test Deleted test cases that are no longer testable according to the spec. * Fix multi-import tests -Delete obsolete code relating to offsets -Propagate dedicated memory change * Fix error handling Some subtests did not fail on incorrect result. Changes to macros to fail, so this does not occur again. * Delete invalid test cases Test cases are not related to this extension. * External memory test Add support for any handle type supported by the platform. Change-Id: I6765fde5e7929988f49bfbf2df2f41d5263b6abc * Update multi-import tests to use new semaphore types * Fix formatting * Addressed review comments. Deleted VULKAN_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_WIN32_NT_KMT as it appears to be redundant.

* Increase the number of work items used by the allocations test The test uses a fixed number of work items to process very large buffers and images. As devices support more and more memory, this leads to an ever-increasing amount of work done in each work item. This results in some implementations and devices hitting timeout issues. Furthermore, a greater number of work items can provide performance benefits on some devices. Long term, this test should be redesigned to scale the number of threads dynamically as a function of the max allocation size. Signed-off-by: Kevin Petit <kevin.petit@arm.com> * formatting and add parentheses --------- Signed-off-by: Kevin Petit <kevin.petit@arm.com>

* allocations: Fix stack overflow * check format fixes

…e GWS (#1856) Modify the existing condition to include extremely small LWS like 1x1 on large GWS values

…1853) Reduce the loop from 1000000 to 500000 since the former value makes the test run too long and cause system issues on certain platforms

Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

The main sources of warnings were: * Printing of a `size_t` which requires the `%zu` specifier. * Printing of `cl_long`/`cl_ulong` which is now done using the `PRI*64` macros to ensure portability across 32 and 64-bit builds. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

* Replace OBSOLETE_FORAMT with OBSOLETE_FORMAT In imageHelpers.cpp and few other places in image tests, OBSOLETE_FORMAT is misspelled as OBSOLETE_FORAMT. Fix misspelling by replcaing it with OBSOLETE_FORMAT. Fixes #1769 * Remove code guarded by OBSOLETE_FORMAT Remove code guarded by OBSOLETE_FORMAT as suggested by review comments Fixes #1769 * Fix formating issues for OBSOLETE_FORMAT changes Fix formatting issues observed in files while removing code guarded by OBSOLETE_FORMAT Fixes #1769 * Some more formatting fixes Some more formatting fixes to get CI clean Fixes #1769 * Final Formating fixes Final formatting fixes for #1769

* Fix format in the test scope * Add user params to limit testing Add parameters to reduce amount of testing. Helpful for debugging or for machines with lower performance. * Restore default value * Print info only if testing params bigger than 0.

Remove an assigned-to but unused variable. Reenable the Wunused-but-set-variable warning for the conversions suite, as it now compiles cleanly with this warning enabled. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

* Fix bug of conversion from long to double It the input is long type, it should be load as long type, not ulong. * update long2float

Fix the ULP error calculation for the `exp` and `exp2` builtins in relaxed math mode for the full profile. Previously, the `ulps` value kept being added to while verifying the result buffer in a loop. `ulps` could even become a `NaN` when the input argument being tested was a `NaN`. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

* Enable LARGEADDRESSAWARE for 32 bit compilation 32-bit executables built with MSVC linker have only 2GB virtual memory address space by default, which might not be sufficient for some tests. Enable LARGEADDRESSAWARE linker flag for 32-bit targets to allow tests to handle addresses larger than 2 gigabytes. https://learn.microsoft.com/en-us/cpp/build/reference/largeaddressaware-handle-large-addresses?view=msvc-170 Signed-off-by: Guo, Yilong <yilong.guo@intel.com> * Apply suggestion Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com> --------- Signed-off-by: Guo, Yilong <yilong.guo@intel.com> Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>

This function (do_test) starts by testing write and read individually. Both of them can have errors. When readwrite image is not supported, the function returns TEST_SKIPPED_ITSELF potentially masking errors leading to the test returning EXIT_SUCCESS even with errors along the way.

…for test_spir (#1866) * modernize CMakeLists for test_spir * add the operating system release to the sccache key * include the math brute force function list vs. building it twice

The source files for the spirv-new tests were using the older Khronos license instead of the proper Apache license. Fixed the license in all source files.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

* Updated semaphore tests to use clSemaphoreReImportSyncFdKHR. Additionally updated common semaphore code to handle spec updates that restrict simultaneous importing/exporting of handles. * Fix build issues on CI * gcc build issues * Make clReImportSemaphoreSyncFdKHR a required API call if cl_khr_external_semaphore_sync_fd is present. * Implement signal and wait for all semaphore types.

It seemed to be a typo; the comment says that it tries to fetch local size for a subgroup count with above max WG size, but it just used the previous subgroup count. The test on purpose sets a SG count to be a larger number than the max work-items in the work group. Given the minimum SG size is 1 WI, it means that there can be a maximum of maximum work-group size of SGs (of 1 WI of size). Thus, if we request a number of SGs that exceeds the local size, the query should fail as expected.

* basic SPIR-V 1.3 testing support * updated script to compile for more SPIR-V versions * switch to general SPIR-V versions test * update copyright text and fix license * improve output while test is running * check for higher SPIR-V versions first * fix formatting

When the math brute force test printed the platform version it always printed information for the first platform in the system, which could be different than the platform for the passed-in device. Fixed by querying the platform from the passed-in device instead.

* Minor fixes in mutable dispatch tests. * Fix size of newWrapper in MutableDispatchSVMArguments. * Fix errnoneus clCommandNDRangeKernelKHR call. Signed-off-by: John Kesapides <john.kesapides@arm.com> * * Set the row_pitch for imageInfo in MutableDispatchImage1DArguments and MutableDispatchImage2DArguments. The row_pitch is used by get_image_size() to calculate the size of the host pointers by generate_random_image_data. Signed-off-by: John Kesapides <john.kesapides@arm.com> --------- Signed-off-by: John Kesapides <john.kesapides@arm.com>

* initial version of the test with placeholders for linkonce_odr linkage * add OpExtension SPV_KHR_linkonce_odr extension * add check for extension * switch to actual LinkOnceODR linkage * fix formatting * add a test case to ensure a function with linkonce_odr is exported * add back the extension check * fix formatting * undo compiler optimization and actually add the call to function a

In C and C++ all functions have external linkage by default. Also remove the unused `gMTdata` and `test_pipe_functions` declarations. Fixes #1137 Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

…1770) * Added cl_khr_fp16 extension support for test_decorate from spirv_new, work in progres * Complemented test_decorate saturation test to support cl_khr_fp16 extension (issue #142) * Fixed clang format * scope of modifications: -changed naming convention of saturation .spvasm files related to test_decorate of spirv_new -restored float to char/uchar saturation tests -few minor corrections * fix ranges for half testing * fix formating * one more formatting fix * remove unused function * use isnan instead of std::isnan isnan is currently implemented as a macro, not as a function, so we can't use std::isnan. * fix Clang warning about inexact conversion --------- Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>

enable the CTS to run on custom devices

* initial support for cl_khr_expect_assume Tests expect with 64-bit SPIR-V binaries. * add support for assume testing with 64-bit binaries * add 32-bit SPIR-V files * fix formatting * address review comments

All of these warnings stem from printing `size_t` types, which should be done using the `z` length modifier. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

* Was causing a build error with GN * fill_and_shuffle_safe_values() in subhelpers.cpp calls std::shuffle() * std::shuffle is defined in <algorithm>

CL_DEVICE_MAX_WORK_GROUP_SIZE is specified to fill in a size_t. By asking it to fill in an uninitialised cl_long, on platforms where size_t is smaller than cl_long, the high bits of the cl_long remain uninitialised.

Use the `z` length modifier for printing `size_t` types. Also fix a typo in the error messages. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Using `GLOB` here breaks incremental builds when switching between branches (e.g. when trying out a pull request). The CMake documentation discourages use of `GLOB` to collect a list of source files, so list all source files explicitly. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

…1680) * [subgroups][non_uniform_broadcast] Fix broadcasting index generation The subgroup size may not be greater than `NR_OF_ACTIVE_WORK_ITEMS`. Broadcasting index needs to be reduced in that case. Otherwise, if subgroup size == `NR_OF_ACTIVE_WORK_ITEMS` == 4, then we will encounter "divide-by-zero" error when evaluating `bcast_index % (n - NR_OF_ACTIVE_WORK_ITEMS)`. * Revert "[subgroups][non_uniform_broadcast] Fix broadcasting index generation" This reverts commit 9bbab53. * [subgroups][non_uniform_broadcast] Fix broadcasting index generation Dynamically activate half of the work items in the current subgroup instead of hardcoding as `NR_OF_ACTIVE_WORK_ITEMS`. * Apply suggestion

* Add NULL CL_MEM_HOST_PTR check for clGetMemObjectInfo The spec requires implementations return NULL for CL_MEM_HOST_PTR when the flags passed at memory object creation time do not contain CL_MEM_USE_HOST_PTR CTS was not checking this. Add the same check. Fixes #1752 * Add NULL CL_MEM_HOST_PTR check for all flag combinations As part of suggestions to #1801, add NULL CL_MEM_HOST_PTR check for all flag combinations. Fixes #1752 * Fix formatting issues

* Added command buffer with full mutable dispatch test According to #1481 issue description, point 2.1 * Corrected the test to handle all available mutable properties According to #1481 issue description, point 2.1

When reporting errors from `clCreateCommandQueueWithProperties`, report the correct property names. In particular: `CL_QUEUE_DEVICE` should be `CL_QUEUE_ON_DEVICE`. `CL_QUEUE_DEFAULT` should be `CL_QUEUE_ON_DEVICE_DEFAULT`. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Node.js 16 actions are deprecated, so update to v4 which uses Node 20. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

…one (#1911) * harness: correct include and sort warning redirecting incorrect #include <sys/errno.h> to <errno.h> Signed-off-by: David Heidelberg <david@ixit.cz>

* Added new tests for simultaneous use with mutable dispatch -cross queue simultaneous use -in-order queue with simultaneous use According to issue description #1481 * Several corrections applied: -reordered Skip conditions to check valid simultaneous_use_support flag -removed unnecessary SetUpKernel call -initialize kernel and memory buffers from BasicCommandBufferTest instead BasicMutableCommandBufferTest * Corrections for command buffer creation to request simultaneous property

…date (#1919) * Added new test to cover multiple comands dispatch in one enqueued update According to issue description #1481 * clang format correction * Few minor corrections * cosmetic corrections

Add support for `CL_UNORM_INT_101010_2` in the `get_pixel_size` helper function. This fixes the following tests: * memInfo_image_from_buffer_positive * image_from_buffer_alignment_negative * imageInfo_image_from_buffer_positive Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>

`inOrderStr` and `outOrderStr` are both written into `orderName`, which may not fit as all three are the same size. Decrease the sizes of `inOrderStr` and `outOrderStr`. The new sizes are still sufficiently large to hold the result of `get_order_string`. This commit only affects the error path and does not change the printed output. Error logs before and after this commit should not differ. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

* Added test to cover overwritten update of mutable parameters According to issue description #1481 * cosmetic corrections * Corrections due to code review

* Added test to cover iterative mutable argument update According to issue description #1481 * cosmetic correction * clang format fix * Corrections due to code review

Avoid casting to `uint64_t` in some places; instead keep the types as `size_t` and use the `%z` length modifier, or as `uint32_t` and use the `%u` specifier. For printing of 64-bit types, use the `PRI*64` macros from <cinttypes> to ensure portability across 32 and 64-bit builds. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

* Shader -> SPIR-V at CTS build time (#1849) Instead of relying on prebuilt checked-in SPIR-V files, compile available shaders at CTS build time. * Add dependency on glslc (available as part of VULKAN_SDK). * Add optional build flag BUILD_GLSL_SHADERS, OFF by default. * Remove pre-built SPIR-V files * Compile Shader -> SPIR-V at CTS build time * Use glslangValidator for shader -> spirv * Add glslangValidator tool for shader -> spirv * Refactor glslangValidator tool retrieval * Address review comments * Use add_subdirectory() instead of include() * Use glslang instead of glslangValidator * Update Github actions CI to install Vulkan SDK

There appears to have been some confusion over `uint_mask` during the initial reviews of the subgroup tests. Add a comment to clarify the purpose of the mask. Use a 32-bit all-ones mask (`0xffffffff`) instead of a 64-bit all-ones mask to further clarify the intent, that is, don't delay discarding the upper 32 bits until the assignment but mask them out immediately. Fixes #1203 Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

We compute the reference values using unsigned types exclusively, even when the input type is signed. This fixes one place where an signed type was inadvertently used.

`log_error` was invoked from a template function, but the format specifiers weren't adjusted for the template parameter types. Use a stringstream for printing instead. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

* Corrections to mutable arguments tests -added verification of device capabilities against mutable arguments -corrected fail of 2 tests with Construction Kit -general cleanup * cleanup corrections * restored relaxed version of mutable arguments tests * corrections to strengthen the test around SVM arguments

* Added negative tests for clGetCommandBufferInfo * Replaced param_value_size values from 0 to sizeof() - 1

Multi-context test was not correctly testing cross-context functionality. Use semaphore import/export mechanism to signal across contexts.

Printing of a `size_t` requires the `%zu` specifier. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

…1915)

* cl_copy_images * cl_get_info * cl_fill_image * cl_read_write_image * kernel_image_methods * IMAGE1D_BUFFER cannot be created with (USE_|ALLOC_|COPY_)_HOST_PTR * do not allow mipmap with 1D buffer * adjust M to be within maximum_sizes and max_pixels * remove unused variables * make sure M will never be 0 * fix region[0] after refactoring removing mipmap * fix formatting * format with clang-format-11 * fix image1d_buffer creation with gEnablePitch * add missing case in switch * use align_malloc when CL version is at least 2.0 * use CL_DEVICE_NUMERIC_VERSION and align_free * fix free of pitch buffer * fix formatting * fix formatting * fix data->is_aligned

These aren't included or built anywhere.

This is 7-year old CMake code that never did anything because the function invocation is missing the PROPERTIES keyword. Adding the keyword results in build errors, so just drop the dead code since everything seems to be working without it anyway.

Only report an error (and include the error code), but don't throw an exception as that would call `terminate`. Failure to release resources is not fatal in other parts of the CTS. This fixes `-Wterminate` warnings: warning: ‘throw’ will always call ‘terminate’ [-Wterminate] note: in C++11 destructors default to ‘noexcept’ Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

#1928) * Added negative tests for clRetainCommandBufferKHR, clReleaseCommandBufferKHR, clFinalizeCommandBufferKHR * Added blocking the clEnqueueCommandBufferKHR call on a user event * Changed cl_event to clEventWrapper

* Added negative tests for clEnqueueCommandBufferKHR * Added blocking the clEnqueueCommandBufferKHR call on a user event * Added finalizing buffer before enqueuing

The `test_compiler compiler_defines_for_extensions` test did not free all `malloc`'ed memory. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

According to description #1668

According to work plan from issue #1058

According to description #1668

Isuue #875 clarified that CL_INVALID_BUFFER_SIZE should be returned if clCreateBuffer is passed a pointer returned by clSVMAlloc as its host_ptr and the size of the buffer exceeds the size of the SVM allocation. Add a new negative test to ensure CL_INVALID_BUFFER_SIZE is returned when the size of buffer exceeds the size of the SVM allocation. Fixes #1701

Add support for cl_ext_image_raw10_raw12 testing on test_image_streams. Signed-off-by: John Kesapides <john.kesapides@arm.com>

Add acquire/release commands where appropriate. This is related to 1886.

…tion (#1932)

Prevent the compiler from optimizing away initialization loops

Adds cl_khr_kernel_clock test. Also fixes failure in the compiler defines for extension compiler subtest when cl_khr_kernel_clock is supported.

test_common/harness/integer_ops_test_info.h is using std::vector but is not including the header. This is breaking on Google internal CI.

According to description #1668

Added Code changes for 1D, 1DList, 3D, 3DList and test cases.

Except for SYNC_FD, current implementation doesn't import exported OpenCL semaphore in Vulkan and ends up doing signal and wait on essentially two unrelated semaphores (one created in OpenCL and one in Vulkan). Since OpenCL exports the semaphore, import that in Vulkan to perform signal/wait on the same underlying payload.

The specification states that `clEnqueueMapImage` and `clEnqueueMapBuffer` should return NULL on error. Ensure this is checked. This testing gap was caught by a compiler warning about `dataPtr` being written but not read. With this fix, there are no more Wunused-but-set-variable warnings in this test, so reenable the warning. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

According to the [specification](https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_C.html#kernel-clock-functions), the work_group and sub_group variants have an `_` in them. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Currently we don't escape subnormal values when generating image data. In sampler read tests, we use `!=` to check the two values even when it is floating-point data, which requires the two values are bitwise equal. However, a sampler might flush subnormal values, causing the test case to fail. In this patch, when generating random image data, we escape subnormal values.

The values in `src` are indices into an array in `get_order_string()`. Not initializing `src` resulted in out of bounds accesses there. It seems that when the out of bounds accesses happened, the result of `get_order_string()` was not actually used, so at least the test was not using random data. Fix the issue as it prevents a clean run of this test with e.g. AddressSanitizer. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

#1942) This PR addresses the first part of #1691 issue and #1875 issue.

…age]KHR (#1941) According to description #1668

According to work plan from issue #1058 Corrections to general test: -removed duplication of separate tests for each element of `PrintfTestType` vector, instead `doTest` procedure would iterate over vector related to specific `PrintfTestType` automaticaly -fixed procedure to assemble kernel source so it can accept only one parameter of the function ( eg. `printf("%%");` ) -incorporated important modifications from #1940 to avoid expected conflicts -warnings fixes, minor corrections, clang format Extension for string testing: -special symbols -nested symbols -all ascii characters -added new type of test `TYPE_FORMAT_STRING` to verify format string only (according to request from the issue)

Co-authored-by: riteshv <riteshv@qti.qualcomm.com>

…1971) The Image_from_buffer_alignment_negative test creates images with incorrect pitches by adding 1 and tests whether the image creation fails. Devices that return 1 for either of CL_IMAGE_REQUIREMENTS_ROW_PITCH_ALIGNMENT_EXT, CL_IMAGE_REQUIREMENTS_SLICE_PITCH_ALIGNMENT_EXT or CL_IMAGE_REQUIREMENTS_BASE_ADDRESS_ALIGNMENT_EXT will successfully create the image and therefore fail the test. This change allows to skip the image creation in this case as the error condition (pitch % pitch_alignment != 0) will not be triggered for these devices.

Merge the `fp16-staging` branch into `main`, adding fp16 (`half`) testing to the conversions and math bruteforce tests. --------- Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com> Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com> Signed-off-by: Guo, Yilong <yilong.guo@intel.com> Signed-off-by: John Kesapides <john.kesapides@arm.com> Co-authored-by: Marcin Hajder <marcin.hajder@gmail.com> Co-authored-by: Ewan Crawford <ewan@codeplay.com> Co-authored-by: Wawiorko, Grzegorz <grzegorz.wawiorko@intel.com> Co-authored-by: Sreelakshmi Haridas Maruthur <sharidas@quicinc.com> Co-authored-by: Harald van Dijk <harald@gigawatt.nl> Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com> Co-authored-by: Haonan Yang <haonan.yang@intel.com> Co-authored-by: Ahmed Hesham <117350656+ahesham-arm@users.noreply.github.com> Co-authored-by: niranjanjoshi121 <43807392+niranjanjoshi121@users.noreply.github.com> Co-authored-by: Wenwan Xing <wenwan.xing@intel.com> Co-authored-by: Yilong Guo <yilong.guo@intel.com> Co-authored-by: Romaric Jodin <89833130+rjodinchr@users.noreply.github.com> Co-authored-by: joshqti <127994991+joshqti@users.noreply.github.com> Co-authored-by: Pekka Jääskeläinen <pekka.jaaskelainen@tuni.fi> Co-authored-by: imilenkovic00 <155085410+imilenkovic00@users.noreply.github.com> Co-authored-by: John Kesapides <46718829+JohnKesapidesARM@users.noreply.github.com> Co-authored-by: Aharon Abramson <aharon.abramson@mobileye.com>

`create_single_kernel_helper` invokes `clBuildProgram` and sets `-cl-std` to the latest version supported by the context. The vast majority of tests are using `create_single_kernel_helper` instead of the `..._create_program` variant, so use the former for the sake of consistency. --------- Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Test that verifies `CL_INVALID_QUEUE_PROPERTIES` is returned from `clCreateCommandQueue`, `clCreateCommandQueueWithProperties`, and `clCreateCommandQueueWithPropertiesKHR` to match spec wording > CL_INVALID_QUEUE_PROPERTIES if values specified in properties are valid but are not supported by the device.

The atomic operations are tested with generic pointers but in a way where the compiler can infer the original pointer address space. This commit adds tests specifically for the case where the compiler cannot make inferences. Test that the correct address is used with atomics when the address is group variant and invariant.

In binary_float.cpp, copysign is special cased. All the reference functions there take double arguments, except for reference_copysign which takes float. This commit copies that approach to special case copysign in binary_double.cpp as well: all the reference functions there take long double arguments, but this commit changes reference_copysignl to take double. The rationale for this in binary_float applies equally to binary_double: conversions of NAN are not required to preserve its sign bit. On architectures where conversion of NAN resets the sign bit, copysign fp64 would return incorrect reference results.

Default version coming with Ubuntu 22.04 that the CI now uses.

clGetDeviceIDs 'num_devices' output parameter is described as: > num_devices returns the number of OpenCL devices available that match device_type. but the _test_events out_of_order_event_waitlist_multi_queue_multi_device_ test expects that after calling: `clGetDeviceIDs(platform, CL_DEVICE_TYPE_ALL, 2, two_device_ids, &number_returned);` the content of number_returned needs to be 2, but it should be valid to return a larger number. --------- Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>

test_decorate was checking for half-precision NAN incorrectly, calling cl_half_from_float where cl_half_to_float was intended, causing a wrong expected result. test_decorate was also printing the expected and actual results reversed, printing "got -1, want 0", when our implementation already returned 0.

Simplify code by returning directly instead of using goto statements. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

@bashbaug

… negative results (#1965) According to work plan from #1691 After consultations with @bashbaug I skipped this case: `CL_INVALID_VALUE if any of the semaphore objects specified by sema_objects requires a semaphore payload and sema_payload_list is NULL`

) The verification code assumes the hardware uses CL_HALF_RTE, which causes a mismatch computation results when the hardware uses RTZ. Fix to use the hardware's default rounding mode.

We've had a couple of bugs inside mesa/rusticl processing %% correctly. I've added those cases locally to make sure all corner cases are properly handled.

- when calling command buffer APIs, test with `command_queue != NULL` should return `CL_INVALID_VALUE` only if the device doesn't support `cl_khr_command_buffer_multi_device` (added `Skip`) - some tests enqueued commands with multiple invalid arguments, e.g. `clCommandCopyImageToBufferKHR` with two images and invalid sync points. AFAIK the order of argument checking is not defined, so implementation can return any valid error value for such API calls, but the tests assumed only one particular error would be returned. Fix the API calls to be unambiguous.

#1957) …sts logged error

This aligns with unary_float.cpp.

Half precision math functions are fully tested as of #1975. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

The removed macros were never used. Use the more common `ARRAY_SIZE` macro instead of defining an identical `NELEMS` macro. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

The main sources of warnings were: * Printing of a `size_t` which requires the `%zu` specifier. * Printing of 64-bit values which is now done using the `PRI*64` macros to ensure portability across 32 and 64-bit builds. * Calling log_error with a format string of `"%f %f %f %f"` but specifying only three arguments. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Adds a missing test case for OpExpectKHR with boolean sources.

Even on the common code path (i.e., no error paths taken), test_computeinfo failed to release its allocated memory, preventing a clean run with LeakSanitizer. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

…1981) According to work plan from issue #1691

According to work plan from issue #1058 Added new case `TYPE_MIXED_FORMAT_RANDOM` which focus on three factors: -data before conversion flags - this is randomly generated ascii string -randomly generated conversion flags - integer or floating point, for each flag specific argument is generated -data after conversion flags - this is randomly generated ascii string Moreover, due to fact in case of `TYPE_MIXED_FORMAT_RANDOM` test is generated on the fly, logging of negative result was extended.

Merge image_array_copy, image_array_copy3d as they share a lot of common code. Signed-off-by: John Kesapides <john.kesapides@arm.com> Signed-off-by: John Kesapides <john.kesapides@arm.com>

Signed-off-by: John Kesapides [john.kesapides@arm.com](mailto:john.kesapides@arm.com)

Signed-off-by: John Kesapides <john.kesapides@arm.com> Signed-off-by: John Kesapides <john.kesapides@arm.com>

The `vulkan-wrapper` helper library's purpose is to eliminate the need to link targets directly to Vulkan, and load it dynamically instead at runtime, using `dlopen` and `LoadLibrary`. Remove the direct linking of the Vulkan library from targets that link to `vulkan-wrapper`. Fixes #1999 Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>

Instead of selecting an arbitrary number for the number of parallel build jobs, use CMake's `--parallel` option instead. Option was introduced in version 3.12, GitHub runners currently use CMake version 3.29.6 so this is supported. Fixes #2003 Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>

clang-format has already been disabled here. Make the function list a bit easier to read. Make the currently commented out functions stand out better on a line of their own. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Since GCC 13 some headers are no longer included transitively through C++ Standard Library headers. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

…tainSemaphoreKHR negative results (#1976) According to work plan from issue #1691 Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>

The computeinfo test already checks that the cl_khr_fp16 extension is available before querying `CL_DEVICE_HALF_FP_CONFIG`, but never actually made the `CL_DEVICE_HALF_FP_CONFIG` query. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

The `skipTestingRelaxed` check suffers the following problems: - The use of `skipTestingRelaxed` in the `if` seems reversed: when skipping correctness testing using the `-l` command line option, this variable causes correctness testing to be run for relaxed-mode `tan` regardless. - Accuracy testing should only be skipped for derived `tan` implementations. Non-derived `tan` implementations must still be tested for accuracy, so the condition for setting the `skipTestingRelaxed` variable is incomplete. - It is unclear why only `tan` is conditionalized here. There are other functions such as `tanpi` for which one would expect identical behaviour. The actual skipping of accuracy checks for derived implementations happens in `Test()`, so just remove `skipTestingRelaxed` as it does not seem to add any value. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

MSVC on Windows was previously omitted from the list of CI platforms that use sccache. Unify the CMAKE_CACHE_OPTIONS used for all CI platforms. In the case of a 100% cache hit, this cuts down the average checks time from 8 minutes to 4 minutes, example: https://github.com/ahesham-arm/OpenCL-CTS/actions/runs/9896449792

…#2015) Fixed: #2009

Issue: #1058

The defines inside this header were not used anywhere. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Completely outdated. Confuses people. Signed-off-by: Kevin Petit <kevin.petit@arm.com>

according to work plan for issue #1058

…UPS_KHR flag with mutable dispatch (#1991) Added new tests for CL_MUTABLE_DISPATCH_ASSERT_NO_ADDITIONAL_WORK_GROUPS_KHR with mutable dispatch according to this test plan #1897 Co-authored-by: Banan Ashkar <banan.ashkar@mobileye.com>

The handling of NaN values in the templated function was incorrect due to improper initialization of the input data source. Specifically, the function ZeroNanToIntCases used a global pointer gIn, which was not correctly set or did not point to the same data as the local input pointer s used in the non-templated implementation. to solve the issue I updated the templated function ZeroNanToIntCases to take an additional parameter for the input data source. and then passed the correct input data (s) to the templated function during its invocation. Co-authored-by: Banan Ashkar <banan.ashkar@mobileye.com>

The math_brute_force test has a link-check-only mode to quickly test if all math functions are present. In link-check-only mode, most tests return immediately after kernel compilation, but some tests also run the kernel and read back the result data before returning. Running the kernels takes a lot more time, defeating the purpose of the `-l` mode. Break out at the start of the main `for` loops in link-check-only mode instead of returning directly, so that each test can still log its trailing message (in most cases just a `\n`). Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

The kernel_read_write tests have a lot of duplicate code. These are the next steps to reducing the duplication, by using the functions in test_common.cpp as common for 1D, 1D array and 2D array. --------- Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com> Co-authored-by: Ahmed Hesham <117350656+ahesham-arm@users.noreply.github.com>

…1997) Skip the correctly rounded divide (divide_cr) and sqrt (sqrt_cr) tests for fp16 and fp64. The corresponding build option to enable correctly rounded divide and sqrt is named `-cl-fp32-correctly-rounded-divide-sqrt` and the description refers only to "single precision floating-point", so this option should not apply to fp16 or fp64. The specification states that fp16 and fp64 divide and sqrt must be correctly rounded for the full profile, without needing any additional build options. This is already tested by the regular divide and sqrt tests. For the embedded profile the ULP requirement is non-zero, but there is no build option to request a correctly rounded implementation anyway. Fixes #1901 . Relates to #1996 . Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Add test to check that clSetCommandQueueProperty successfully changes command queue properties. Fixes #904 Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com> Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>

Some conformance tests use directly the size returned by the runtime for max memory size to allocate buffers. This doesn't leave enough memory for the system to run the tests.

1. Fix memory leak by making `context2` use the context wrapper. 2. Create two separate events to associate with the two calls to `clEnqueueSignalSemaphoresKHR()`, as events cannot be reused. Also delete the unused helper function `semaphore_external_cross_queue_helper()` (which was a duplicate of `external_semaphore_cross_queue_helper()` anyway).

…rtiesKHR negative results (#1962) According to work plan from #1691, new clSemaphoreWrapper introduced to avoid duplication of code

Fix error return and TEST_PASS for negative SVM tests Fix review comments from #1802 Fixes #1964

…reRounding (#2038) This makes it literally impossible for drivers to constant fold the IsTininessDetectedBeforeRounding kernel. Sure, drivers might have should respect volatile here, but I'm not convinced this is actually required by the spec in a very strict sense, because here there are no side-effects possible in the first place. And as far as I know, constant folding is allowed to give different results than an actual GPU calculation would. In any case, passing the constants via kernel arguments makes this detection more reliable and one doesn't have to wonder why the fma test is failing. Side note: this was the last bug (known as of today) I had to fix in order being able to make a CL CTS submission for Apple Silicon devices.

according to work plan for issue #1058

Basic explicit_s2v: The verification step was always using round to even when converting a float to half even for round to zero cores. Commonfns degrees: The verification step was only taking into account infinities and not values that over/underflow. This resulted in an incorrect error calculation. E.g: double cpu_result = 175668.85998711039; cl_half gpu_result = 31743; // this is 65504 when converting to float, we overflowed. float error = (cpu_result - gpu_result) * some_factor; The fix adds the check if( (cl_half) reference == test ) before calculating the error.

Use format aware memory comparison instead of memcmp.

…#1977) Issue: #1930

#1900 Tested on POCL, callback is not called.

according to work plan for issue #1058

The length modifier is required with a vector specifier. Fixes #2039 Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

windows default stack size is 1M, BUFFER_SIZE is 2 * 1024 * 1024, use array with BUFFER_SIZE elemets on stack can exceed available stack size limits.

The main sources of warnings were: * Printing of a `size_t` which requires the `%zu` specifier. * Printing of `cl_long`/`cl_ulong` which is now done using the `PRI*64` macros to ensure portability across 32 and 64-bit builds. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

An implementation may not support exportable semaphore, subtests available in cl_khr_external_semaphore assumes support for exportable semaphore, resulting in failure on such implementation. Allow implementations to use importable semaphore in such cases.

…aphoreTestBase infrastructure (#2029)

The various forms of `TestInfoBase` have many members in common, so avoid duplicating the struct definition and move it to `common.h`. Provide a description and initializer for every struct member, and drop initializations done with `memset`. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Include `cmath` instead of `math.h` in C++ mode under MSVC, to avoid build errors inside the header. Ideally we would not condition this on `_MSC_VER`, but issue 1833 currently prevents doing so. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

CTS changes to reflect the spec changes merged in KhronosGroup/OpenCL-Docs#1045 and requires header updates from KhronosGroup/OpenCL-Headers#245 Tested using OCK implementation from uxlfoundation/oneapi-construction-kit#501

This is an update to #2050, with updates from the main branch. --------- Co-authored-by: Ewan Crawford <ewan@codeplay.com>

Printing of a `size_t` requires the `%zu` specifier. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Add cases for `CL_INCOMPATIBLE_COMMAND_QUEUE_KHR`, `CL_INVALID_COMMAND_BUFFER_KHR` and `CL_INVALID_SYNC_POINT_WAIT_LIST_KHR`. Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>

fixes #2040 * Compiles the Vulkan SPIR-V files in a directory based off of CMAKE_CURRENT_BINARY_DIR. * Changes the search path for the Vulkan SPIR-V files to this directory rather than a semi-arbitrary set of directories.

All existing tests in `test_image_streams`, that are capable of testing image formats using the `CL_UNORM_INT_101010_2` data type, now do so.

In test_event_enqueue_wait_for_events_run_test: * Decrease TEST_COUNT to 10 * Add clFinish to queues

Add a type argument so that in the future we can request the ULP requirement for fp16 and fp64 types through `getAllowedUlpError` too. Contributes to #867 Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

fixes a few minor issues introduced by #1984. edit: Tested with the updated command buffer emulation layer on a device that supports out-of-order queues and SVM and all of the `test_cl_khr_mutable_dispatch` tests pass.

…2064) This will ensure consistent output on any conforming implementation. Note that the specification does not define the output style when precision is missing. --------- Signed-off-by: Cui, Dele <dele.cui@intel.com>

All of these are already set in the top-level `CMakeLists.txt` nowadays, so no need to repeat them in the test's own `CMakeLists.txt`. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

glutInit double called in CTS CLGL test case code, which will lead to an error: freeglut (./test_gl): illegal glutInit() reinitialization attempt root cause is in: test_conformance/gl/main.cpp:343 if (glEnv->Init(&argc, (char **)argv, CL_TRUE)) the glEnv->Init has already called in same file line:260, the function glutInit in glEnv->Init can not be called twice, then a error will occur although all the gl / CLGL cases are passed. Then in the full quick CTS running it will appear: (12-Jul 03:54:01) BEGIN OpenCL-GL Sharing : PASSED sub-test. PASSED 23 of 23 tests. (12-Jul 04:01:48) FAILED OpenCL-GL Sharing : (467s, test 34/53) Although all the gl/CLGL cases are passed, but this group test is judged to failed. This issue already been found in #1885 And fixed partly by: 02471c8 But I found in setup_osx.cpp, the glutInit still has double init issue, I add the same fix like previous fix, can you please help to review? Signed-off-by: Honglei Huang <Honglei1.Huang@amd.com> Co-authored-by: Honglei Huang <Honglei1.Huang@amd.com>

…esKHR (#2006) According to work plan from issue #1691

according to work plan for issue #1058

'./test_image_streams test_mipmaps CL_FILTER_NEAREST' already skips many tests, but doesn't do so for cl_ext_image_raw10_raw12, causing it to fail. Add a check similar to how it is done in the other tests already. On a device which doesn't support mipmap'd access: W/o fix ``` ./test_image_streams test_mipmaps CL_FILTER_NEAREST ... 1Darray passed 2Darray... ----------------------------------------------------- This device does not support cl_khr_mipmap_image. Skipping mipmapped image test. ----------------------------------------------------- ----------------------------------------------------- This device does not support cl_khr_mipmap_image. Skipping mipmapped image test. ----------------------------------------------------- 2Darray passed cl_image_requirements_size_ext_negative... ... image_from_buffer_read_positive passed cl_ext_image_raw10_raw12... ---- Supported 2D read formats for this device for cl_ext_image_raw10_raw12---- CL_R CL_UNSIGNED_INT_RAW10_EXT 0 CL_R CL_UNSIGNED_INT_RAW12_EXT 0 ------------------------------------------- read_image (normalized float coords, uint results) ***************************** [CL_R CL_UNSIGNED_INT_RAW10_EXT 1] - CL_FILTER_NEAREST - CL_ADDRESS_CLAMP_TO_EDGE - NORMALIZED ERROR: clBuildProgram failed! (CL_BUILD_PROGRAM_FAILURE from <>/OpenCL-CTS/test_common/harness/kernelHelpers.cpp:844) Build options: -cl-std=CL3.0 Original source is: ------------ #pragma OPENCL EXTENSION cl_khr_mipmap_image: enable __kernel void sample_kernel( read_only image2d_t input, sampler_t imageSampler, __global float *xOffsets, __global float *yOffsets, __global uint4 *results , float lod) { int tidX = get_global_id(0), tidY = get_global_id(1); unsigned int lod_int = (unsigned int) lod; int width_lod = (get_image_width(input) >> lod_int) ?(get_image_width(input) >> lod_int):1 ; int offset = tidY*width_lod + tidX; float2 coords = (float2)( (float)( xOffsets[offset] ), (float)( yOffsets[offset] ) ); results[offset] = read_imageui( input, imageSampler, coords , lod); }Build not successful for device <>, status: CL_BUILD_ERROR Build log for device <> is: ------------ <source>:1:26: warning: unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring #pragma OPENCL EXTENSION cl_khr_mipmap_image: enable ^ <source>:9:22: error: no matching function for call to 'read_imageui' results[offset] = read_imageui( input, imageSampler, coords , lod); ^~~~~~~~~~~~ error: Compiler frontend failed (error code <unknown>) ``` With fix: ``` ./test_image_streams test_mipmaps CL_FILTER_NEAREST .... image_from_buffer_read_positive... image_from_buffer_read_positive passed cl_ext_image_raw10_raw12... ---- Supported 2D read formats for this device for cl_ext_image_raw10_raw12---- CL_R CL_UNSIGNED_INT_RAW10_EXT 0 CL_R CL_UNSIGNED_INT_RAW12_EXT 0 ------------------------------------------- ----------------------------------------------------- This device does not support cl_khr_mipmap_image. Skipping mipmapped image test. ----------------------------------------------------- cl_ext_image_raw10_raw12 passed PASSED sub-test. PASSED 18 of 18 tests. ```

Buffer size needs to be greater than or equal the image row pitch which was not the case.

Fixes: 1. Multi import diff ctx subtest which acquires/releases external memory via queue not associated with the context in which memory was imported. 2. Platform/Device info subtests to handle different platforms and availability of the query.

Signed-off-by: John Kesapides <john.kesapides@arm.com> --------- Signed-off-by: John Kesapides <john.kesapides@arm.com>

Due to change request from #2037

#1578

Adds test to confirm that the timestamp returned from clGetEventProfilingInfo for an event on a device and a device timestamp queried from the same device are in the same timebase. Fixes #753 Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com> --------- Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>

It was disabled because lack of reference implementation. However the reference implementation exists. Then no reason to start testing these functions.

…nd images/test_1D_buffer (#2062) fixes several issues: * `generic_address_space` test: add check for program scope variables. The test uses both generic AS and program-scope variables, however it only checked the generic-AS presence in `clGetDeviceInfo`. * `compiler/test_compiler_defines_for_extensions.cpp`: add `cl_khr_command_buffer_multi_device` to the list of recognized extensions * `command_buffer_event_sync.cpp`: add delays for testing `clSetEventCallback` - according to specification, these can be executed asynchronously (in a separate thread) by the OpenCL implementation, hence the event callback is not quaranteed to be called before `clFinish()` returns. Existing test `events/test_callbacks.cpp` also waits for callback with loops of usleep. * `images/kernel_image_methods/test_1D_buffer.cpp`: fix allocation size being too small for the 1D buffer backing the image --------- Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>

Comparing test (of type cl_half) with 0.0f is incorrect because cl_half is a typedef of uint16_t (or unsigned short in c) Co-authored-by: Tejswini Nimburkar <tnimburk@qti.qualcomm.com>

Increase Vulkan version to 1.1, which is required to support vkGetBufferMemoryRequirements2.

before: Filling constant buffer with 553805440 cl_ints (-2079745536 bytes). after: Filling constant buffer with 553805440 cl_ints (2215221760 bytes).

According to work plan for issue #1058

Replace the occurrences of 0.0f == test' with 0.0f == HTF(test)'. The types of 0.0f and test are not the same, so the equality comparison will get undesired result when the test represents a -0.0h (i.e., test is 32768=0x8000). In this situation, 0.0f == test will be false, but 0.0f == HTF(test) will be true. Revise each if-statement to match the OpenCL s7.5.3 Item 4, specifically modify to check that the result is subnormal instead of checking that it is zero. "If the result of 3. is a sub-normal before rounding, the result may be flushed to zero" Co-authored-by: tnimburk <tnimburk@qti.qualcomm.com>

Fixes narrowing conversion build errors in test_common Removing disable of narrowing errors in main CMakeLists.txt and moving it down to specific test_conformance suite's CMakeLists.txt where there are many more build errors revealed from this fix. Fixes a few simple issues under test_conformance in the process. Contributes #787 Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com> --------- Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>

some fixes we've been carrying in our CTS fork: * fix UB in `command_buffer_event_sync.cpp`: enqueue of two commands in two separate queues, with both using the same buffer argument, and no synchronization between the commands. * fix UB in `command_buffer_test_barrier.cpp`: missing synchronization between zeroing command and command-buffer using two separate queues * make `test_thread_dimensions.cpp` thread-safe to avoid spurious errors.

The extension tests in `test_conformance/extensions` have not matching entries in the `opencl_conformance_tests_*.csv` files. This means that they are missed from conformance runs by vendors who use these files. I've included the new extensions in the full and quick CSV files as they don't have vast combinations of tests to run like bruteforce or conversions. I've put `cl_khr_dx9_media_sharing` in the `test_conformance/opencl_conformance_tests_d3d.csv` CSV as like the other tests there the test binary is conditional built only on a Windows platform. I've created a new `opencl_conformance_tests_vulkan.csv ` file for testing the `cl_khr_external_semaphore` extension, as creation of the binary is conditional on the Vulkan SDK being enabled environment. Any other tests that require the Vulkan SDK in future can also be added there.

Following the re-enablement of narrowing warnings, this fixes a compilation error when running the `ubuntu 22.04 arm` GitHub action. Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>

…ies (#2063) According to comments from issue #1875 --------- Co-authored-by: Nikhil Joshi <nikhilj@nvidia.com>

Vulkan descriptors are being programmed incorrectly, use fix from 1676 in other subtest Co-authored-by: dcrawley <dcrawley@qti.qualcomm.com>

- generate shader files in VULKAN_TEST_RESOURCES directory - allows for outside CMakeLists to specify arbitrary destination Co-authored-by: dcrawley <dcrawley@qti.qualcomm.com>

…rms (#2117) Looks like #2063 has a "narrowing" warning that is now treated as an error and is hence causing CI builds to fail. Applies the same fix as #2107 to fix this warning.

The test is missing clFinish after clEnqueueSVMUnmap. Add clFinish after clEnqueueSVMUnmap. Signed-off-by: Xin Jin <xin.jin@arm.com>

Commit b6941b6 ("Add fp16 testing to conversions and bruteforce (#1975)", 2024-06-18) introduced a behavioural change for non-half tests. The `-cl-denorms-are-zero` option could be added for non-half tests such as `char_rtn_float` even when `gForceFTZ` was `false`. Fix the condition by also taking the input and output types into account. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

This PR adds targeted testing for SPIR-V 1.4 features. Specifically, this PR adds testing for: 1. The new Image Operand for SignExtend and ZeroExtend. 2. The new Loop Controls MinIterations, MaxIterations, IterationMultiple, PeelCount, and PartialCount.

This PR adds targeted testing for SPIR-V 1.4 features. Specifically, this PR adds testing for the NoSignedWrap and NoUnsignedWrap decorations. We can reuse large parts of the testing for the `cl_khr_spirv_no_integer_wrap_decoration` extension to test the SPIR-V 1.4 feature.

When importing a Vulkan external image, query and pass OpenCL a row pitch if OpenCL is assuming linear for the imported external handle type. Additionally fix a bug where OpenCL is being told to create mipmapped images at all times. --------- Co-authored-by: dcrawley <dcrawley@qti.qualcomm.com>

Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>

This test did not pass the `-cl-std=` flag when building the program. As a result, for an OpenCL 3.0 device, the program will be "compiled using the highest OpenCL C 1.x language version supported" by the device. However this will force uniform work-group sizes which leads to a `CL_INVALID_WORK_GROUP_SIZE` error. To fix this, use the `create_single_kernel_helper()` helper function which will automatically get the device version and pass that to `-cl-std=` when building the program. --------- Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>

In test_mem_host_flags, some events are not released. In fact, they are not used, so they can be removed altogether.

All existing tests in `test_image_streams`, that are capable of testing image formats using the `CL_UNORM_INT_2_101010_EXT` data type, do so. Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>

Fix a "format string is not a string literal (potentially insecure)" warning. There is no security issue here as the format string argument is constructed using a stringstream right before. Fix this occurrence anyway to allow enabling the warning globally. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

- read CL_DEVICE_TYPE_ when specified like other conformance tests - reject non-GPU device types Co-authored-by: dcrawley <dcrawley@qti.qualcomm.com>

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

#1235

This PR adds targeted testing for the SPIR-V 1.4 instructions OpPtrEqual, OpPtrNotEqual, and OpPtrDiff.

Call `getAllowedUlpError` to obtain the allowed ULP error for all of the half type (fp16) tests. The aim is to standardise obtaining the desired ULP requirement and pave the way for adding the Embedded Profile ULP errors. Contributes to #867 Contributes to #1685 Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Rounding up the clusters_results size to avoid out of bounds access when subgroup_size is not a multiple of cluster_size.

When cl_khr_fp16 is not supported, this property is not available. Note that the spec is different for CL_DEVICE_{PREFERRED,NATIVE}_VECTOR_WIDTH_HALF: those properties are always available and return 0 if cl_khr_fp16 is not supported, so those checks are left as is.

Add a `format` parameter to the macro, to be able to specify how to print the expected and actual parameter values. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Removes `using namespace std` and adds `std::` explicitly instead, which is usually on calls to `min`. This is generally best practice, and it also might be helpful when there are the same function names in the std namespace and in the global namespace (e.g. #1833).

This PR adds targeted testing for more SPIR-V 1.4 features. Specifically, this PR adds testing for OpDecorateString, OpMemberDecorateString, and the UserSemantic decoration.

Fixes #1366 according to task description.

…ws (#2088) Currently Intel® C++ Compiler Classic (ICC) is supported to build OpenCL-CTS on Windows. This compiler has been discontinued since the second half of 2023. Instead, Intel recommends that users transition to use the LLVM-based Intel® oneAPI DPC++/C++ Compiler (ICX). This change is to enable users to build OpenCL-CTS with ICX on Windows.

Image height is initialized to 0. But the size calculation should assume a height of 1.

Current class wrapper of the CTS test framework allows getting the pointer of the private member object. This puts the object at risk of losing its original value if the pointer gets reassigned, causing a memory leak and potentially other problems. This happens to the "clMemWrapper kernel" used by mutable_command_work_groups tests, where the "clMemWrapper kernel" gets initialised by the default basic setup function and then it gets reassigned by the build_program_create_kernel_helper() helper function through pointer. This patch fixes this issue by updating mutable_command_work_groups tests: instead of calling basic setup function and then initialise the "clMemWrapper kernel" object again in the helper function, it now overrides the basic setup function to make sure the "clMemWrapper kernel" will be assigned only once. Signed-off-by: Xin Jin <xin.jin@arm.com>

Add coverage to import Vulkan resources (memory and semaphore) in Windows via named NT handles. If no name is given during resource creation, then use NT handles for import. If a name is given, have an option to either use that name or get the NT handle and use that for import. Resolves KhronosGroup/OpenCL-Docs#943

- negative testing for semaphore functions is accomplished in semaphore tests, as well as create image in the api test Co-authored-by: dcrawley <dcrawley@qti.qualcomm.com>

When creating a CL semaphore object from a Vulkan semaphore one, we explicitly pass `-1` as the file descriptor value in the case of `VULKAN_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD`. According to the CL specification: > The special value -1 for fd is treated like a valid sync file > descriptor referring to an object that has already signaled. The > import operation will succeed and the semaphore will have a > temporarily imported payload as if a valid file descriptor had > been provided. The test currently checks that the semaphore payload is unsignalled, unconditionally, which is incorrect. Changed the test to check for the correct expected payload value. Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>

This PR adds targeted testing for a few remaining miscellaneous SPIR-V 1.4 features: * Variables in the Function storage class can have a NonWriteable decoration. * OpCopyMemorySized can have two optional memory operands. * OpSelect can have composite operands that are not vectors.

Fixes #1833 according to task description.

Re-enable a disabled external semaphore test. Delete obsolete subtests that remain in comments.

…th barrier (#2068) Fixes #1979 according to task description.

This change refactors the following files: 1. test_imagearraycopy.cpp 2. test_arrayimagecopy.cpp The purpose of refactoring is to allow passing different buffer and image flags to the test function as well as passing customisable test functions. Signed-off-by: Michael Rizkalla <michael.rizkalla@arm.com>

None of these are referenced anywhere in the code, so remove them. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

This PR adds targeted testing for the SPIR-V 1.4 instruction OpCopyLogical.

see #1982

When comparing scanlines for SNORM images, take into account that -1.0 can be exactly represented in two different ways. --------- Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>

Some platforms (Windows in our case) seem to need this.

test_copy_1D.cpp: num_mip_levels is a cl_uint, so don't cast and just print using `%u`. test_pipe_info.cpp: arg_type_qualifier is a 64-bit wide bitfield, so print in hexadecimal format using the correct length modifier. test_device_partition.cpp: it is not clear what the bit width of `cl_device_partition_property` should be, so cast the operands to align with the format specifiers. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com> Co-authored-by: Ewan Crawford <ewan.cr@gmail.com>

The following tests under `spirv_new`: * `op_branch_conditional` * `op_phi` * `op_selection_merge` were using randomly generated `cl_int` values, and storing the difference between them as a `cl_int`. If one of the generated values is negative and large enough, while the other is positive and large enough, the difference then becomes a larger value that cannot be represented using `cl_int`. Switch the tests to use `cl_uint` instead, and update the relevant spvasm{32,64} files to use `OpULessThan` instead of `OpSLessThan`. Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>

On Ubuntu, use the system's package manager, `apt`, to download and install the cross-compilers for Arm and AArch64. This replaces downloading the compilers as tarballs. To ensure that the correct version of the compiler is used when calling one without the version suffix, e.g. `aarch64-linux-gnu-gcc`, use `update-alternatives`. On Linux, the compilers for `x86_64`, `arm`, and `aarch64` will now correctly use the filesystem root as their sysroots, i.e. `/usr/include` will be used when searching for headers, instead of each compiler providing its own.

And use in device_timer suite. Signed-off-by: Kévin Petit <kpet@free.fr>

Merge KhronoGroup/OpenCL-CTS: main into nikhiljnv/OpenCL-CTS:KhronosGroup-master #43

Are you sure you want to change the base?

Merge KhronoGroup/OpenCL-CTS: main into nikhiljnv/OpenCL-CTS:KhronosGroup-master #43

Commits on Oct 10, 2023

Commits on Oct 17, 2023

Commits on Oct 30, 2023

Commits on Nov 7, 2023

Commits on Nov 9, 2023

Commits on Nov 14, 2023

Commits on Nov 23, 2023

Commits on Nov 29, 2023

Commits on Dec 5, 2023

Commits on Dec 12, 2023

Commits on Dec 14, 2023

Commits on Dec 20, 2023

Commits on Dec 28, 2023

Commits on Jan 9, 2024

Commits on Jan 16, 2024

Commits on Jan 17, 2024

Commits on Jan 23, 2024

Commits on Jan 30, 2024

Commits on Feb 6, 2024

Commits on Feb 9, 2024

Commits on Feb 13, 2024

Commits on Feb 27, 2024

Commits on Mar 7, 2024

Commits on Mar 8, 2024

Commits on Mar 11, 2024

Commits on Mar 12, 2024

Commits on Mar 18, 2024

Commits on Mar 19, 2024

Commits on Mar 20, 2024

Commits on Mar 26, 2024

Commits on Mar 27, 2024

Commits on Apr 2, 2024

Commits on Apr 4, 2024

Commits on Apr 5, 2024

Commits on Apr 9, 2024

Commits on Apr 15, 2024

Commits on Apr 16, 2024

Commits on Apr 19, 2024

Commits on Apr 22, 2024

Commits on Apr 26, 2024

Commits on May 7, 2024

Commits on May 14, 2024

Commits on May 21, 2024

Commits on May 22, 2024

Commits on May 28, 2024

Commits on May 29, 2024

Commits on May 30, 2024

Commits on Jun 4, 2024

Commits on Jun 11, 2024

Commits on Jun 18, 2024

Commits on Jun 25, 2024

Commits on Jun 27, 2024

Commits on Jul 2, 2024

Commits on Jul 8, 2024

Commits on Jul 9, 2024

Commits on Jul 11, 2024

Commits on Jul 12, 2024

Commits on Jul 16, 2024

Commits on Jul 18, 2024

Commits on Jul 23, 2024

Commits on Jul 29, 2024

Commits on Aug 6, 2024

Commits on Aug 13, 2024

Commits on Aug 20, 2024

Commits on Aug 27, 2024

Commits on Aug 29, 2024

Commits on Sep 2, 2024

Commits on Sep 3, 2024

Commits on Sep 6, 2024

Commits on Sep 12, 2024

Commits on Sep 16, 2024

Commits on Sep 17, 2024

Commits on Sep 19, 2024

Commits on Sep 20, 2024

Commits on Sep 24, 2024

Commits on Oct 1, 2024

Commits on Oct 3, 2024