Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: subscribe on websocket #144

Open
paranic opened this issue Aug 31, 2017 · 9 comments
Open

question: subscribe on websocket #144

paranic opened this issue Aug 31, 2017 · 9 comments

Comments

@paranic
Copy link

paranic commented Aug 31, 2017

i am sorry but it is not clear on the README
does websocket implements subscribe?

@nicolasff
Copy link
Owner

They do, but websockets were implemented while the protocol was still under development and I would not recommend using this feature. It is half-baked and probably unsafe, which is why it is disabled by default.

@ccvca
Copy link
Contributor

ccvca commented Apr 17, 2019

Should be fixed by #156

@ccvca
Copy link
Contributor

ccvca commented Apr 19, 2019

@paranic
You may try it again with the recent Version.

@AllanOricil
Copy link

How can I set the Websocket = true inside the Docker image?

@nicolasff
Copy link
Owner

@AllanOricil you'll need to change the config file and rebuild the docker image. Alternatively you can start from an existing docker image and use RUN with sed to change the boolean from false to true and tag an image from that.

@zak-b2c2
Copy link

Is this now safe to use? Thanks

@nicolasff
Copy link
Owner

@zak-b2c2 I have not made any changes to the implementation since this comment, and am unlikely to be able to work on this in the near future.

I would not recommend using this feature.

@zak-b2c2
Copy link

Understood, thanks for the clarification

@m986883511
Copy link

RUN sed -i '2i"websockets": true,' /etc/webdis.prod.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants