From e913ad431d98ac3ab46c423270273498209cb720 Mon Sep 17 00:00:00 2001
From: Nicholas Griffin <nicholas.griffin@bbc.co.uk>
Date: Sun, 25 Aug 2024 19:29:28 +0100
Subject: [PATCH] chore: changing it up a bit

---
 .../homepage/search-result-item.tsx           |  8 +---
 .../components/homepage/search-results.tsx    | 42 +++++++++++++++++--
 2 files changed, 40 insertions(+), 10 deletions(-)

diff --git a/apps/web/app/components/homepage/search-result-item.tsx b/apps/web/app/components/homepage/search-result-item.tsx
index 49efeb9..9423014 100644
--- a/apps/web/app/components/homepage/search-result-item.tsx
+++ b/apps/web/app/components/homepage/search-result-item.tsx
@@ -94,13 +94,9 @@ function getBadgeColor(score: number): string {
   }
 }
 
-function getRandomImagePosition(): string {
-  const positions = ['left', 'top', 'right'];
-  return positions[Math.floor(Math.random() * positions.length)];
-}
-
 export const SearchResultItem = ({
   result,
+  imagePosition = 'left',
 }: {
   result: {
     metadata: {
@@ -113,10 +109,10 @@ export const SearchResultItem = ({
     };
     score: number;
   };
+  imagePosition?: string;
 }) => {
   const matchPercentage = Math.round(result.score * 100);
   const badgeColor = getBadgeColor(matchPercentage);
-  const imagePosition = getRandomImagePosition();
 
   return (
     <li>
diff --git a/apps/web/app/components/homepage/search-results.tsx b/apps/web/app/components/homepage/search-results.tsx
index 85244f7..a7dff7f 100644
--- a/apps/web/app/components/homepage/search-results.tsx
+++ b/apps/web/app/components/homepage/search-results.tsx
@@ -3,20 +3,50 @@ import { ArrowRight } from 'lucide-react';
 import { SearchResultItem } from './search-result-item';
 import { Button } from '../ui/button';
 
+const getImagePosition = (
+  index: number,
+  result: {
+    metadata: {
+      title: string;
+      description: string;
+      url: string;
+      author?: string;
+      published?: string;
+      updated?: string;
+    };
+    score: number;
+  }
+): string => {
+  const positions = ['left', 'top', 'right'];
+
+  // Use the length of the title and description to influence the position
+  const titleLength = result?.metadata?.title?.length || 0;
+  const descriptionLength = result?.metadata?.description?.length || 0;
+  const score = result?.score || 0;
+
+  // Generate a pseudo-random number based on the title and description lengths
+  const randomFactor =
+    (titleLength + descriptionLength + Math.round(score * 100) + index) %
+    positions.length;
+
+  return positions[randomFactor];
+};
+
 export const SearchResults = ({
   data,
 }: {
   data: {
     count: number;
     matches: {
-      title: string;
-      description: string;
-      url: string;
       metadata: {
         title: string;
         description: string;
         url: string;
+        author?: string;
+        published?: string;
+        updated?: string;
       };
+      score: number;
     }[];
   };
 }) => (
@@ -26,7 +56,11 @@ export const SearchResults = ({
       <ul className="space-y-4">
         {data?.matches?.length > 0 ? (
           data.matches.map((result, index) => (
-            <SearchResultItem key={index} result={result} />
+            <SearchResultItem
+              key={index}
+              result={result}
+              imagePosition={getImagePosition(index, result)}
+            />
           ))
         ) : (
           <p className="text-muted-foreground">Loading...</p>