Add Contribute page #148
Open
Add Contribute page #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
temporarily deployed
to
nhs-prototyp-92-create--8qo2uz
|
@vickytnz I like this but wonder if it’s maybe a bit long? Can I have a go at cutting it down a bit, if you’re ready? (It's in Draft so wasn't sure if you want reviews yet or not). Also not sure about the "Soon, you’ll be able to..." section - could we just add that stuff when it happens rather than making promises for the future? |
|
@frankieroberto yeah sounds good - will change this to a PR to change. Agree that for the future stuff we can just say: 'we will add other things as the become available- if you have an idea contact us' |
|
@vickytnz it's already a PR! 😂 I’ll hit the "Ready for review" button. 😄 |
frankieroberto
temporarily deployed
to
nhs-prototyp-92-create--8qo2uz
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
I will remove but am half waiting for this to be a thing as I have experienced in a lot of places that people on Surface Pros have Github blocked, let's see if this becomes a thing Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
|
Changes
|
frankieroberto
changed the title
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Merged
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
|
Final tweaks I have also removed all of the 'add your own' text from each section.
|
frankieroberto
added a commit
that referenced
this pull request
Nov 27, 2024
This adds a "primary nav" with 3 items: * Get started * Guides * Support "Contribute" could be added when #148 is merged. I’ve not included "Page templates" as that page feels less valuable longer-term (eg if the NHS website templates get moved to a plugin or something). Adding the primary nav possibly means that some of the breadcrumbs could be removed or shortened (eg the "Home" breadcrumb link on Support feels a bit odd now?), but the Service Manual website has both, so maybe it’s fine? There’s no "current section" indicator for now, but we can adopt that when it gets added to the header in the next major release of NHS frontend (hopefully). Part of #93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added contribution page as a light touch version of the Service Manual pages.
This pull request includes: