Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eukulele duplicates, and other Eukulele small bugs #201

Closed
erikrikarddaniel opened this issue Oct 23, 2023 · 1 comment
Closed

Eukulele duplicates, and other Eukulele small bugs #201

erikrikarddaniel opened this issue Oct 23, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@erikrikarddaniel
Copy link
Member

Description of the bug

In a project I ran for colleagues I found duplicates in the summary table. It turned out this was due to duplicates in the taxonomy_estimation/prokka-estimated-taxonomy.out.gz file. The ones I've looked at have different scores, so it seems we're not taking that into account:

0       FJKOKEPI_01799  species Bacteria; Gammaproteobacteria; Pseudomonadales; Porticoccaceae; HTCC2207; HTCC2207      HTCC2207        357.8   0
0       FJKOKEPI_01799  order   Bacteria; Gammaproteobacteria; Pseudomonadales  Pseudomonadales 287.0   1
...
0       CJDPECOA_05216  species Bacteria; Alphaproteobacteria; Puniceispirillales; Puniceispirillaceae; UBA8309; UBA8309        UBA8309 594.3   0
0       CJDPECOA_05216  family  Bacteria; Alphaproteobacteria; Puniceispirillales; Puniceispirillaceae; UBA8309; UBA8309        UBA8309 418.3   0

This should make this rather easy to deal with.

(What's a bit interesting above is that the last two lines are identical except for the score and the rank! Must be a Eukulele bug.)

Secondly, I also found that the summary table has capitalized names, e.g. Domain. It would be good to have all lowercase (IMO).

Thirdly, when one doesn't supply a database name, the summary file gets [] in the filename. This also affects the overall summary file in the form of [] in the column header for the eukulele counts.

Command used and terminal output

No response

Relevant files

No response

System information

No response

@erikrikarddaniel erikrikarddaniel added the bug Something isn't working label Oct 23, 2023
@erikrikarddaniel erikrikarddaniel self-assigned this Oct 23, 2023
@erikrikarddaniel erikrikarddaniel mentioned this issue Oct 23, 2023
10 tasks
@danilodileo
Copy link
Collaborator

we merged PR #202 so we can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants