Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups page improvements #947

Open
2 of 3 tasks
victorlin opened this issue Jul 8, 2024 · 4 comments
Open
2 of 3 tasks

Groups page improvements #947

victorlin opened this issue Jul 8, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@victorlin
Copy link
Member

victorlin commented Jul 8, 2024

Potential tasks

Ideas considered but not pursued

  • Remove tiles in favor of resource listing (ref)
@victorlin victorlin added the enhancement New feature or request label Jul 8, 2024
@victorlin
Copy link
Member Author

victorlin commented Jul 8, 2024

Remove tiles in favor of resource listing

Rather than removing it, I think it can be improved. With an expandable tiles container, /groups would look visually similar to /pathogens. Keeping the tiles maintains that similarity, though the behavior on click is slightly different.

An idea to integrate the two parts of the page:

  1. Make the click behavior of /groups act as a filter similar to the behavior on /pathogens.
  2. Make the resource listing titles clickable (to preserve links to group pages). This is currently in a PR: f137aea
  3. Make the resource listing show groups without resources (to preserve links to all groups).

@joverlee521
Copy link
Contributor

Make the resource listing show groups without resources (to preserve links to all groups).

Ah right, I hadn't considered groups without datasets! We should definitely preserve links to all groups even if they do not have published resources.

I think the expandable cards container makes sense for the /pathogens page because we plan to have curated cards. Will the expandable display still make sense if we display ~all groups (we're already at 30+ public groups) or would it feel like clutter?

@joverlee521
Copy link
Contributor

Use group logo/title in card

Related to #870 which also has a task to display group logos in the resource listing.

@victorlin
Copy link
Member Author

Will the expandable display still make sense if we display ~all groups (we're already at 30+ public groups) or would it feel like clutter?

I'll make a PR so we can get a better sense of it interactively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants