Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable link outs for private datasets #1019

Open
tsibley opened this issue Sep 12, 2024 · 0 comments
Open

Disable link outs for private datasets #1019

tsibley opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tsibley
Copy link
Member

tsibley commented Sep 12, 2024

arose from conversation with CDC

Datasets in private groups are not available for viewing on other platforms: they require CORS requests made with credentials (in this case, HTTP cookies), and 1) we deny credentialed CORS requests and 2) most external services are making uncredentialed requests (because they're more likely to succeed).

We should disable the link outs with an appropriate explanation. Possibly similar to how the Nextclade link out is disabled when the dataset is not compatible.

This will require coordination with Auspice, or potentially a larger redesign of how link outs work such that we move them completely out of Auspice itself and into a nextstrain.org customization of it.

Separately, we could consider options for opening up private groups to link outs/integrations, but that's a larger conversation with more implications to consider.

@tsibley tsibley added the bug Something isn't working label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant