From da67505c507077d3a83653d31e9b38a397ba328e Mon Sep 17 00:00:00 2001 From: stefan-niedermann Date: Tue, 31 Dec 2019 10:28:58 +0100 Subject: [PATCH] Disallow toggling checkboxes from within the preview #157 #287 --- .../android/fragment/NotePreviewFragment.java | 45 +++++++++---------- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java index 6f266eade..032ea2b72 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java @@ -4,7 +4,6 @@ import android.graphics.Typeface; import android.os.Bundle; import android.preference.PreferenceManager; -import android.text.TextUtils; import android.text.method.LinkMovementMethod; import android.util.TypedValue; import android.view.LayoutInflater; @@ -76,28 +75,28 @@ public void onActivityCreated(@Nullable Bundle savedInstanceState) { markdownProcessor.factory(TextFactory.create()); markdownProcessor.config( MarkDownUtil.getMarkDownConfiguration(noteContent.getContext()) - .setOnTodoClickCallback((view, line, lineNumber) -> { - String[] lines = TextUtils.split(note.getContent(), "\\r?\\n"); - /* - * Workaround for a bug when checkbox is the last line: - * When (un)checking a checkbox which is in the last line, every time it gets toggled, the last character of the line gets lost. - */ - if ((lines.length - 1) == lineNumber) { - if(lines[lineNumber].contains("- [ ]")) { - lines[lineNumber] = lines[lineNumber].replace("- [ ]", "- [x]"); - } else { - lines[lineNumber] = lines[lineNumber].replace("- [x]", "- [ ]"); - } - - } else if (lines.length >= lineNumber) { - lines[lineNumber] = line; - } - changedText = TextUtils.join("\n", lines); - noteContent.setText(markdownProcessor.parse(changedText)); - saveNote(null); - return line; - } - ) +// .setOnTodoClickCallback((view, line, lineNumber) -> { +// String[] lines = TextUtils.split(note.getContent(), "\\r?\\n"); +// /* +// * Workaround for a bug when checkbox is the last line: +// * When (un)checking a checkbox which is in the last line, every time it gets toggled, the last character of the line gets lost. +// */ +// if ((lines.length - 1) == lineNumber) { +// if(lines[lineNumber].contains("- [ ]")) { +// lines[lineNumber] = lines[lineNumber].replace("- [ ]", "- [x]"); +// } else { +// lines[lineNumber] = lines[lineNumber].replace("- [x]", "- [ ]"); +// } +// +// } else if (lines.length >= lineNumber) { +// lines[lineNumber] = line; +// } +// changedText = TextUtils.join("\n", lines); +// noteContent.setText(markdownProcessor.parse(changedText)); +// saveNote(null); +// return line; +// } +// ) .build()); setActiveTextView(noteContent); noteContent.setText(markdownProcessor.parse(note.getContent()));