Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerlessHandler: error handling for URI parsing #2821

Merged
merged 2 commits into from
Aug 19, 2024
Merged

ServerlessHandler: error handling for URI parsing #2821

merged 2 commits into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. ServerlessHandler: error handling for URI parsing 

    To address issues with the recent serverless enhancements discovered
through local dev testing with the Node.js tool 'serverless':

- Don't append a port value to a URI string that already contains one
- If the URI string construction or parsing fails for any reason, log an
  error and return `nil` so that further processing of the function
  invocation is not impacted

These issues are thought to only be reproducible outside of AWS, but
it's good to be proactive with a bit of extra caution.
    @fallwith
    fallwith committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    aef39fb View commit details
    Browse the repository at this point in the history

  2. serverless handler tested: comment disambiguation 

    simply say "without AWS" to refer to local testing
    @fallwith
    fallwith committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c869cd9 View commit details
    Browse the repository at this point in the history