Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf tests: fix arg passing #2217

Merged
merged 1 commit into from
Sep 19, 2023
Merged

perf tests: fix arg passing #2217

merged 1 commit into from
Sep 19, 2023

Conversation

fallwith
Copy link
Contributor

  • now that we wrap the perf tests in a Rails wrapper, the outer ARGV needs to be passed to the inner one
  • fix straggler that wasn't previously converted to use an iteration count

resolves #2212

@fallwith
perf tests: fix arg passing
68cdb9b 
- now that we wrap the perf tests in a Rails wrapper, the outer `ARGV`
  needs to be passed to the inner one
- fix straggler that wasn't previously converted to use an iteration
  count
@github-actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 94.32% 94%
Branch 85.89% 85%

@fallwith fallwith merged commit ad0165b into dev Sep 19, 2023
28 checks passed
@fallwith fallwith deleted the price_value_selection_nobody_even_comes_close branch September 19, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@hannahramadan hannahramadan Awaiting requested review from hannahramadan hannahramadan is a code owner

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Perf test A/B runs' tabular format seems to be broken
2 participants
@fallwith @kaylareopelle